Change 'bool world_readable' to an enum

Change 'bool world_readable' to an enum

More clear at callsites, and relatively important not to accidentally choose the wrong one.

R=mark@chromium.org

Committed: https://chromium.googlesource.com/crashpad/crashpad/+/68658657739a01fd764e34d7946b6ee5d122e2d1

[scottmg, 2014-12-19 23:19:30]

Patchset #1 (id:1) has been deleted

[Mark Mentovai, 2014-12-19 23:26:33]

LGTM. This is better.

https://codereview.chromium.org/821483002/diff/20001/util/file/file_io.h
File util/file/file_io.h (right):

https://codereview.chromium.org/821483002/diff/20001/util/file/file_io.h#newc...
util/file/file_io.h:178: //! open the file. On POSIX, \a permissions determines
the mask that is passed
value, not mask. Even though there’s mathematically no difference between the
two sides of a bit-AND, we tend to think of the mode argument as the “value” and
the umask as the “mask.”

https://codereview.chromium.org/821483002/diff/20001/util/file/file_io_posix.cc
File util/file/file_io_posix.cc (right):

https://codereview.chromium.org/821483002/diff/20001/util/file/file_io_posix....
util/file/file_io_posix.cc:96: open(path.value().c_str(), flags,
Personally, I don’t like the way clang-format does these now, where different
lines have different numbers of arguments, because it makes the arguments harder
to find. But I won’t fight clang-format if you want to keep it as-is.

[scottmg, 2014-12-19 23:33:14]

https://codereview.chromium.org/821483002/diff/20001/util/file/file_io.h
File util/file/file_io.h (right):

https://codereview.chromium.org/821483002/diff/20001/util/file/file_io.h#newc...
util/file/file_io.h:178: //! open the file. On POSIX, \a permissions determines
the mask that is passed
On 2014/12/19 23:26:32, Mark Mentovai wrote:
> value, not mask. Even though there’s mathematically no difference between the
> two sides of a bit-AND, we tend to think of the mode argument as the “value”
and
> the umask as the “mask.”

Done.

https://codereview.chromium.org/821483002/diff/20001/util/file/file_io_posix.cc
File util/file/file_io_posix.cc (right):

https://codereview.chromium.org/821483002/diff/20001/util/file/file_io_posix....
util/file/file_io_posix.cc:96: open(path.value().c_str(), flags,
On 2014/12/19 23:26:33, Mark Mentovai wrote:
> Personally, I don’t like the way clang-format does these now, where different
> lines have different numbers of arguments, because it makes the arguments
harder
> to find. But I won’t fight clang-format if you want to keep it as-is.

I also dislike this format, but was following what .clang-format said. I'll
switch and send a follow up to fix .clang-format.

[Mark Mentovai, 2014-12-19 23:34:04]

Thanks, I’ve been meaning to figure out which of the various bin-pack options
controls this.

[scottmg, 2014-12-19 23:35:34]

Committed patchset #2 (id:40001) manually as
68658657739a01fd764e34d7946b6ee5d122e2d1 (presubmit successful).