Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(635)

Issue 821383008: Mixed Content: Create a strict-mode Setting. [1/3] (Closed)

Created:
5 years, 11 months ago by Mike West
Modified:
5 years, 11 months ago
CC:
blink-reviews, blink-reviews-dom_chromium.org, dglazkov+blink, eae+blinkwatch, rwlbuis, sof
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Mixed Content: Create a strict-mode Setting. [1/3] It would be nice if an embedder could instruct Blink to always enforce strict mixed content checking. This is the Blink-side of a patch to enable such a control. Patch 1: [THIS PATCH] Patch 2: https://codereview.chromium.org/842643002/ Patch 3: https://codereview.chromium.org/841693002 BUG=442662 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187974

Patch Set 1 #

Patch Set 2 : Fix. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -1 line) Patch
M Source/core/frame/Settings.in View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/loader/MixedContentChecker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebSettingsImpl.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/web/WebSettingsImpl.cpp View 1 chunk +5 lines, -0 lines 0 comments Download
M public/web/WebSettings.h View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mike West
Mind taking a look at this series of patches, and telling me whether I'm doing ...
5 years, 11 months ago (2015-01-07 12:22:17 UTC) #2
jochen (gone - plz use gerrit)
lgtm
5 years, 11 months ago (2015-01-07 13:53:27 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/821383008/20001
5 years, 11 months ago (2015-01-07 15:26:19 UTC) #5
commit-bot: I haz the power
5 years, 11 months ago (2015-01-07 15:29:59 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187974

Powered by Google App Engine
This is Rietveld 408576698