Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(513)

Unified Diff: Source/core/css/resolver/ViewportStyleResolver.cpp

Issue 82083002: Move viewport unit resolution to style recalc time (Closed) Base URL: https://chromium.googlesource.com/chromium/blink@master
Patch Set: rebased.. Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/css/resolver/ViewportStyleResolver.cpp
diff --git a/Source/core/css/resolver/ViewportStyleResolver.cpp b/Source/core/css/resolver/ViewportStyleResolver.cpp
index 61894a2458a283c32027c6837af2366d13c7fd3a..731e0254a699e6f313aa37da0e477b98fcedf5b1 100644
--- a/Source/core/css/resolver/ViewportStyleResolver.cpp
+++ b/Source/core/css/resolver/ViewportStyleResolver.cpp
@@ -184,10 +184,7 @@ Length ViewportStyleResolver::viewportLengthValue(CSSPropertyID id) const
CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value.get());
if (primitiveValue->isLength())
- return primitiveValue->computeLength<Length>(CSSToLengthConversionData(m_document->renderStyle(), m_document->renderStyle(), 1.0f));
-
- if (primitiveValue->isViewportPercentageLength())
- return primitiveValue->viewportPercentageLength();
+ return primitiveValue->computeLength<Length>(CSSToLengthConversionData(m_document->renderStyle(), m_document->renderStyle(), m_document->renderView(), 1.0f));
rune 2013/12/04 07:44:06 This change means also viewport descriptors need t
Timothy Loh 2013/12/15 23:41:19 Updated patch to re-resolve on resize.
if (primitiveValue->isPercentage())
return Length(primitiveValue->getFloatValue(), Percent);

Powered by Google App Engine
This is Rietveld 408576698