Move viewport unit resolution to style recalc time

Source/core/css/resolver/ViewportStyleResolver.cpp

 /*
  * Copyright (C) 2012-2013 Intel Corporation. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  *
  * 1. Redistributions of source code must retain the above
  *    copyright notice, this list of conditions and the following
  *    disclaimer.
@@ skipping 166 matching lines @@
         || id == CSSPropertyMaxWidth
         || id == CSSPropertyMinWidth);
 
     RefPtr<CSSValue> value = m_propertySet->getPropertyCSSValue(id);
     if (!value || !value->isPrimitiveValue())
         return Length(); // auto
 
     CSSPrimitiveValue* primitiveValue = toCSSPrimitiveValue(value.get());
 
     if (primitiveValue->isLength())
-        return primitiveValue->computeLength<Length>(CSSToLengthConversionData(m_document->renderStyle(), m_document->renderStyle(), 1.0f));
-
-    if (primitiveValue->isViewportPercentageLength())
-        return primitiveValue->viewportPercentageLength();
+        return primitiveValue->computeLength<Length>(CSSToLengthConversionData(m_document->renderStyle(), m_document->renderStyle(), m_document->renderView(), 1.0f));

[rune, 2013/12/04 07:44:06]

This change means also viewport descriptors need to be recascaded on resize. I
can't see from the code changes that this happens.

An example where the viewport should change on resize:

@viewport { width: 50vw; }

[Timothy Loh, 2013/12/15 23:41:19]

Updated patch to re-resolve on resize.

 
     if (primitiveValue->isPercentage())
         return Length(primitiveValue->getFloatValue(), Percent);
 
     switch (primitiveValue->getValueID()) {
     case CSSValueInternalExtendToZoom:
         return Length(ExtendToZoom);
     case CSSValueAuto:
         return Length();
     default:
         // Unrecognized keyword.
         ASSERT_NOT_REACHED();
         return Length(0, Fixed);
     }
 }
 
 } // namespace WebCore