extensions/browser/api/serial/serial_event_dispatcher.cc - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/browser/api/serial/serial_event_dispatcher.cc

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Fix merge error. Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « extensions/browser/api/serial/serial_event_dispatcher.h ('k') | extensions/browser/api/sockets_tcp/tcp_socket_event_dispatcher.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: extensions/browser/api/serial/serial_event_dispatcher.cc

diff --git a/extensions/browser/api/serial/serial_event_dispatcher.cc b/extensions/browser/api/serial/serial_event_dispatcher.cc

index 309ebdc071fdb99ced327574dccf0aa7ab5349c8..930c1efe29446066ec68e84034ffaf19f6850615 100644

--- a/extensions/browser/api/serial/serial_event_dispatcher.cc

+++ b/extensions/browser/api/serial/serial_event_dispatcher.cc

@@ -87,13 +87,13 @@ void SerialEventDispatcher::StartReceive(const ReceiveParams& params) {

// static

void SerialEventDispatcher::ReceiveCallback(const ReceiveParams& params,

- const std::string& data,

+ const std::vector<char>& data,

serial::ReceiveError error) {

DCHECK_CURRENTLY_ON(params.thread_id);

// Note that an error (e.g. timeout) does not necessarily mean that no data

// was read, so we may fire an onReceive regardless of any error code.

- if (data.length() > 0) {

+ if (data.size() > 0) {

serial::ReceiveInfo receive_info;

receive_info.connection_id = params.connection_id;

receive_info.data = data;