chrome/browser/chromeos/extensions/wallpaper_private_api.h - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/wallpaper_private_api.h

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/values_unittest.cc ('K') | « chrome/browser/chromeos/extensions/wallpaper_function_base.cc ('k') | chrome/browser/chromeos/extensions/wallpaper_private_api.cc » ('j') | chromeos/dbus/shill_third_party_vpn_driver_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/wallpaper_private_api.h

diff --git a/chrome/browser/chromeos/extensions/wallpaper_private_api.h b/chrome/browser/chromeos/extensions/wallpaper_private_api.h

index a5b1c3fae6f4a40d3ab9fc8bee40f6401d978654..4ae74874165955d4989c9f881ccf61f6a30e5e55 100644

--- a/chrome/browser/chromeos/extensions/wallpaper_private_api.h

+++ b/chrome/browser/chromeos/extensions/wallpaper_private_api.h

@@ -5,6 +5,9 @@

#ifndef CHROME_BROWSER_CHROMEOS_EXTENSIONS_WALLPAPER_PRIVATE_API_H_

#define CHROME_BROWSER_CHROMEOS_EXTENSIONS_WALLPAPER_PRIVATE_API_H_

+#include <string>

+#include <vector>

#include "base/threading/sequenced_worker_pool.h"

#include "chrome/browser/chromeos/extensions/wallpaper_function_base.h"

#include "chrome/common/extensions/api/wallpaper_private.h"

@@ -265,7 +268,7 @@ class WallpaperPrivateSaveThumbnailFunction : public AsyncExtensionFunction {

void Success();

// Saves thumbnail to thumbnail directory as |file_name|.

- void Save(const std::string& data, const std::string& file_name);

+ void Save(const std::vector<char>& data, const std::string& file_name);

// Sequence token associated with wallpaper operations. Shared with

// WallpaperManager.