chrome/browser/chromeos/extensions/wallpaper_function_base.cc - Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/wallpaper_function_base.cc

Issue 820673004: json_schema_compiler: Use std::vector<char> for binary values. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@simplify_json_schema

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« base/values_unittest.cc ('K') | « chrome/browser/chromeos/extensions/wallpaper_function_base.h ('k') | chrome/browser/chromeos/extensions/wallpaper_private_api.h » ('j') | chromeos/dbus/shill_third_party_vpn_driver_client.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/wallpaper_function_base.cc

diff --git a/chrome/browser/chromeos/extensions/wallpaper_function_base.cc b/chrome/browser/chromeos/extensions/wallpaper_function_base.cc

index 99b35295d994861b66b6cd815ee1cbca83bb24b6..d5213d4f0212080bba9d6007ef4afbb66b700186 100644

--- a/chrome/browser/chromeos/extensions/wallpaper_function_base.cc

+++ b/chrome/browser/chromeos/extensions/wallpaper_function_base.cc

@@ -48,7 +48,7 @@ class WallpaperFunctionBase::UnsafeWallpaperDecoder

: function_(function) {

}

- void Start(const std::string& image_data) {

+ void Start(const std::vector<char>& image_data) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

// This function can only be called after user login. It is fine to use

@@ -108,7 +108,7 @@ WallpaperFunctionBase::WallpaperFunctionBase() {

WallpaperFunctionBase::~WallpaperFunctionBase() {

}

-void WallpaperFunctionBase::StartDecode(const std::string& data) {

+void WallpaperFunctionBase::StartDecode(const std::vector<char>& data) {

DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));

if (unsafe_wallpaper_decoder_)

unsafe_wallpaper_decoder_->Cancel();