Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(847)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 820203002: Support html br element in AX Tree. (Closed)

Created:
5 years, 12 months ago by shreeramk
Modified:
5 years, 11 months ago
Reviewers:
dmazzoni, aboxhall
CC:
blink-reviews, dglazkov+blink
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Support html br element in AX Tree. HTML content: <html> <body> Text line 2 <br> Text line 2 </body> </html> AX Tree: ROLE_SYSTEM_DOCUMENT READONLY FOCUSABLE IA2_ROLE_SECTION ROLE_SYSTEM_STATICTEXT name='Text line 2 ' ROLE_SYSTEM_WHITESPACE ROLE_SYSTEM_CLIENT ROLE_SYSTEM_STATICTEXT name='Text line 2' This CL depends on https://codereview.chromium.org/820203002/ BUG=116181 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187855

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : rebasing #

Patch Set 4 : Rebasling Layout Tests #

Patch Set 5 : LineBreakRole #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -5 lines) Patch
M LayoutTests/accessibility/img-alt-tag-only-whitespace.html View 1 2 3 1 chunk +2 lines, -2 lines 0 comments Download
M LayoutTests/accessibility/img-alt-tag-only-whitespace-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/accessibility/presentational-elements-with-focus.html View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/accessibility/presentational-elements-with-focus-expected.txt View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M Source/modules/accessibility/AXObject.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M Source/modules/accessibility/AXRenderObject.cpp View 1 2 3 4 2 chunks +5 lines, -0 lines 0 comments Download
M Source/web/AssertMatchingEnums.cpp View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M public/web/WebAXEnums.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
shreeramk
@Dominic: Could you please have a look? I m not sure why the bots are ...
5 years, 12 months ago (2014-12-26 12:39:14 UTC) #2
shreeramk
On 2014/12/26 12:39:14, shreeramk wrote: > @Dominic: Could you please have a look? I m ...
5 years, 12 months ago (2014-12-26 12:41:18 UTC) #3
shreeramk
@Dominic: Now its fine. PTAL. Thanks!!
5 years, 11 months ago (2014-12-29 04:53:43 UTC) #4
dmazzoni
lgtm I might have done this with a role of LineBreakRole rather than WhiteSpaceRole, and ...
5 years, 11 months ago (2015-01-05 09:17:30 UTC) #6
shreeramk
On 2015/01/05 09:17:30, dmazzoni wrote: > lgtm > > I might have done this with ...
5 years, 11 months ago (2015-01-05 09:50:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/820203002/80001
5 years, 11 months ago (2015-01-05 10:05:50 UTC) #9
commit-bot: I haz the power
5 years, 11 months ago (2015-01-05 11:18:32 UTC) #10
Message was sent while issue was closed. 
Committed patchset #5 (id:80001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187855

Powered by Google App Engine
This is Rietveld 408576698