Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8014)

Unified Diff: Source/modules/accessibility/AXRenderObject.cpp

Issue 820203002: Support html br element in AX Tree. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: LineBreakRole Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/modules/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXRenderObject.cpp
diff --git a/Source/modules/accessibility/AXRenderObject.cpp b/Source/modules/accessibility/AXRenderObject.cpp
index 66d3e6796b5184777fd2cff57bb695dddfc471fc..2563e01d96556ee781bc63cff4aebb4c9f13827b 100644
--- a/Source/modules/accessibility/AXRenderObject.cpp
+++ b/Source/modules/accessibility/AXRenderObject.cpp
@@ -279,6 +279,8 @@ AccessibilityRole AXRenderObject::determineAccessibilityRole()
return ListItemRole;
if (m_renderer->isListMarker())
return ListMarkerRole;
+ if (m_renderer->isBR())
+ return LineBreakRole;
if (isHTMLLegendElement(node))
return LegendRole;
if (m_renderer->isText())
@@ -584,6 +586,9 @@ bool AXRenderObject::computeAccessibilityIsIgnored() const
if (controlObject && !controlObject->exposesTitleUIElement() && controlObject->isCheckboxOrRadio())
return true;
+ if (m_renderer->isBR())
+ return false;
+
// NOTE: BRs always have text boxes now, so the text box check here can be removed
if (m_renderer->isText()) {
// static text beneath MenuItems and MenuButtons are just reported along with the menu item, so it's ignored on an individual level
« no previous file with comments | « Source/modules/accessibility/AXObject.h ('k') | Source/web/AssertMatchingEnums.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698