Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h - Issue 820183002: [bindings] Make v8_class[Constructor]::domTemplate use Local<> instead of Handle<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h

Issue 820183002: [bindings] Make v8_class[Constructor]::domTemplate use Local<> instead of Handle<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@new-branch

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceNode.cpp ('k') | Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h

index 8d1e083bcdb7b557232aec1a376a8a577dd754dc..1482668e667e5da79bf1f1d121c1843e3ee287a3 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h

+++ b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h

@@ -20,7 +20,7 @@ namespace blink {

class V8TestInterfaceWillBeGarbageCollectedConstructor {

public:

- static v8::Handle<v8::FunctionTemplate> domTemplate(v8::Isolate*);

+ static v8::Local<v8::FunctionTemplate> domTemplate(v8::Isolate*);

static const WrapperTypeInfo wrapperTypeInfo;

};

@@ -28,7 +28,7 @@ class V8TestInterfaceWillBeGarbageCollected {

public:

static bool hasInstance(v8::Handle<v8::Value>, v8::Isolate*);

static v8::Handle<v8::Object> findInstanceInPrototypeChain(v8::Handle<v8::Value>, v8::Isolate*);

- static v8::Handle<v8::FunctionTemplate> domTemplate(v8::Isolate*);

+ static v8::Local<v8::FunctionTemplate> domTemplate(v8::Isolate*);

static TestInterfaceWillBeGarbageCollected* toImpl(v8::Handle<v8::Object> object)

{

return blink::toScriptWrappable(object)->toImpl<TestInterfaceWillBeGarbageCollected>();