Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp - Issue 820183002: [bindings] Make v8_class[Constructor]::domTemplate use Local<> instead of Handle<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

Issue 820183002: [bindings] Make v8_class[Constructor]::domTemplate use Local<> instead of Handle<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@new-branch

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.h ('k') | Source/bindings/tests/results/core/V8TestNode.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

diff --git a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

index 33af1b28c5289cea140862cbbd4f021dbf473d14..75c7f041484a2b3ff82853045422ba7303fd08a9 100644

--- a/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

+++ b/Source/bindings/tests/results/core/V8TestInterfaceWillBeGarbageCollected.cpp

@@ -134,7 +134,7 @@ static void V8TestInterfaceWillBeGarbageCollectedConstructorCallback(const v8::F

v8SetReturnValue(info, wrapper);

}

-v8::Handle<v8::FunctionTemplate> V8TestInterfaceWillBeGarbageCollectedConstructor::domTemplate(v8::Isolate* isolate)

+v8::Local<v8::FunctionTemplate> V8TestInterfaceWillBeGarbageCollectedConstructor::domTemplate(v8::Isolate* isolate)

{

static int domTemplateKey; // This address is used for a key to look up the dom template.

V8PerIsolateData* data = V8PerIsolateData::from(isolate);

@@ -188,7 +188,7 @@ static void installV8TestInterfaceWillBeGarbageCollectedTemplate(v8::Local<v8::F

functionTemplate->Set(v8AtomicString(isolate, "toString"), V8PerIsolateData::from(isolate)->toStringTemplate());

}

-v8::Handle<v8::FunctionTemplate> V8TestInterfaceWillBeGarbageCollected::domTemplate(v8::Isolate* isolate)

+v8::Local<v8::FunctionTemplate> V8TestInterfaceWillBeGarbageCollected::domTemplate(v8::Isolate* isolate)

{

return V8DOMConfiguration::domClassTemplate(isolate, const_cast<WrapperTypeInfo*>(&wrapperTypeInfo), installV8TestInterfaceWillBeGarbageCollectedTemplate);

}