Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issue 819943006: [bindings] Let getShadowObjectTemplate return Local<>. (Closed)

Created:
5 years, 12 months ago by vivekg_samsung
Modified:
5 years, 12 months ago
Reviewers:
haraken, vivekg, Jens Widell
CC:
arv+blink, blink-reviews, blink-reviews-bindings_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@third-branch
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

[bindings] Let getShadowObjectTemplate return Local<>. R=haraken@chromium.org R=jl@opera.com BUG=424445 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=187679

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M Source/bindings/core/v8/WindowProxy.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/interface.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/templates/interface.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
vivekg
PTAL.
5 years, 12 months ago (2014-12-24 09:36:30 UTC) #2
Jens Widell
LGTM
5 years, 12 months ago (2014-12-24 09:38:09 UTC) #3
haraken
LGTM
5 years, 12 months ago (2014-12-24 09:47:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819943006/1
5 years, 12 months ago (2014-12-24 10:10:12 UTC) #6
commit-bot: I haz the power
5 years, 12 months ago (2014-12-24 10:56:12 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=187679

Powered by Google App Engine
This is Rietveld 408576698