Source/bindings/templates/interface.h - Issue 819943006: [bindings] Let getShadowObjectTemplate return Local<>.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/templates/interface.h

Issue 819943006: [bindings] Let getShadowObjectTemplate return Local<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@third-branch

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/bindings/templates/interface.h

diff --git a/Source/bindings/templates/interface.h b/Source/bindings/templates/interface.h

index 0117b0cd6c2047e1277b795c33972b1a6da6ddff..f48a2805dabc33e88627842470204ede0cb82763 100644

--- a/Source/bindings/templates/interface.h

+++ b/Source/bindings/templates/interface.h

@@ -78,7 +78,7 @@ public:

static ActiveDOMObject* toActiveDOMObject(v8::Handle<v8::Object>);

{% endif %}

{% if interface_name == 'Window' %}

- static v8::Handle<v8::ObjectTemplate> getShadowObjectTemplate(v8::Isolate*);

+ static v8::Local<v8::ObjectTemplate> getShadowObjectTemplate(v8::Isolate*);

{% endif %}

{% for method in methods %}

{% if method.is_custom %}

« no previous file with comments | « Source/bindings/core/v8/WindowProxy.cpp ('k') | Source/bindings/templates/interface.cpp » ('j') | no next file with comments »