Fixed create application shortcuts on Windows/Linux.

Fixed create application shortcuts on Windows/Linux.

r307806 introduced a bug where a user was unable to create shortcuts
from the chrome://extensions page on Windows/Linux. This patch fixes it
by searching for all extensions, rather than just enabled ones.

BUG=443882
Committed: https://crrev.com/88f4581975065ad952cdf30161e00e0578ae746d
Cr-Commit-Position: refs/heads/master@{#309390}

[mitchellj, 2014-12-21 23:19:33]

mitchelljones@chromium.org changed reviewers:
+ tapted@chromium.org

[mitchellj, 2014-12-21 23:19:34]

@tapted, could you please review files as owner? Thanks.

[tapted, 2014-12-22 00:05:09]

https://codereview.chromium.org/819823002/diff/1/chrome/browser/ui/views/crea...
File chrome/browser/ui/views/create_application_shortcut_view.cc (right):

https://codereview.chromium.org/819823002/diff/1/chrome/browser/ui/views/crea...
chrome/browser/ui/views/create_application_shortcut_view.cc:394:
web_app::CreateNonAppShortcut(web_app::SHORTCUT_CREATION_BY_USER,
This doesn't look right. The profile and extension should exist here as well.
The issue in crbug.com/443882 seems to be that the extension is disabled,
whereas CreateShortcutsWithInfo only asks the extension registry for enabled
extensions.

I think options are to:
 a) Disable [gray-out] the `Create shortcuts` button on the app info dialog if
the extension is disabled
 b) Just change CreateShortcutsWithInfo to allow shortcut creation for disabled
extensions. The extension will get auto-enabled if the extension is clicked,
which is a bit weird, but it would restore the old behaviour.

[mitchellj, 2014-12-22 00:32:23]

https://codereview.chromium.org/819823002/diff/1/chrome/browser/ui/views/crea...
File chrome/browser/ui/views/create_application_shortcut_view.cc (right):

https://codereview.chromium.org/819823002/diff/1/chrome/browser/ui/views/crea...
chrome/browser/ui/views/create_application_shortcut_view.cc:394:
web_app::CreateNonAppShortcut(web_app::SHORTCUT_CREATION_BY_USER,
On 2014/12/22 00:05:09, tapted wrote:
> This doesn't look right. The profile and extension should exist here as well.
> The issue in crbug.com/443882 seems to be that the extension is disabled,
> whereas CreateShortcutsWithInfo only asks the extension registry for enabled
> extensions.
> 
> I think options are to:
>  a) Disable [gray-out] the `Create shortcuts` button on the app info dialog if
> the extension is disabled
>  b) Just change CreateShortcutsWithInfo to allow shortcut creation for
disabled
> extensions. The extension will get auto-enabled if the extension is clicked,
> which is a bit weird, but it would restore the old behaviour.

I think option b) here is probably the easiest for now. I've made it to check
ExtensionRegistry::EVERYTHING.

[tapted, 2014-12-22 00:49:08]

lgtm

[mitchellj, 2014-12-22 00:49:34]

The CQ bit was checked by mitchelljones@chromium.org

[commit-bot: I haz the power, 2014-12-22 00:50:15]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819823002/20001

[commit-bot: I haz the power, 2014-12-22 02:38:24]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-22 02:38:25]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[mitchellj, 2014-12-22 02:50:56]

The CQ bit was checked by mitchelljones@chromium.org

[commit-bot: I haz the power, 2014-12-22 02:52:03]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819823002/20001

[commit-bot: I haz the power, 2014-12-22 03:39:08]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-22 03:40:03]

Patchset 2 (id:??) landed as
https://crrev.com/88f4581975065ad952cdf30161e00e0578ae746d
Cr-Commit-Position: refs/heads/master@{#309390}