Fixed create application shortcuts on Windows/Linux.

chrome/browser/ui/views/create_application_shortcut_view.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/views/create_application_shortcut_view.h"
 
 #include <algorithm>
 #include <cmath>
 
 #include "base/bind.h"
@@ skipping 373 matching lines @@
 
 #if defined(OS_WIN)
   creation_locations.in_quick_launch_bar = quick_launch_check_box_ == NULL ?
       NULL : quick_launch_check_box_->checked();
 #elif defined(OS_POSIX)
   // Create shortcut in Mac dock or as Linux (gnome/kde) application launcher
   // are not implemented yet.
   creation_locations.in_quick_launch_bar = false;
 #endif
 
-  web_app::CreateShortcutsWithInfo(web_app::SHORTCUT_CREATION_BY_USER,
-                                   creation_locations,
-                                   shortcut_info_,
-                                   file_handlers_info_);
+  web_app::CreateNonAppShortcut(web_app::SHORTCUT_CREATION_BY_USER,

[tapted, 2014/12/22 00:05:09]

This doesn't look right. The profile and extension should exist here as well.
The issue in crbug.com/443882 seems to be that the extension is disabled,
whereas CreateShortcutsWithInfo only asks the extension registry for enabled
extensions.

I think options are to:
 a) Disable [gray-out] the `Create shortcuts` button on the app info dialog if
the extension is disabled
 b) Just change CreateShortcutsWithInfo to allow shortcut creation for disabled
extensions. The extension will get auto-enabled if the extension is clicked,
which is a bit weird, but it would restore the old behaviour.

[mitchellj, 2014/12/22 00:32:23]

I think option b) here is probably the easiest for now. I've made it to check
ExtensionRegistry::EVERYTHING.

+                                creation_locations, shortcut_info_,
+                                file_handlers_info_);
   return true;
 }
 
 views::Checkbox* CreateApplicationShortcutView::AddCheckbox(
     const base::string16& text, bool checked) {
   views::Checkbox* checkbox = new views::Checkbox(text);
   checkbox->SetChecked(checked);
   checkbox->set_listener(this);
   return checkbox;
 }
@@ skipping 131 matching lines @@
     close_callback_.Run(false);
   return CreateApplicationShortcutView::Cancel();
 }
 
 void CreateChromeApplicationShortcutView::OnAppInfoLoaded(
     const web_app::ShortcutInfo& shortcut_info,
     const extensions::FileHandlersInfo& file_handlers_info) {
   shortcut_info_ = shortcut_info;
   file_handlers_info_ = file_handlers_info;
 }