Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(207)

Issue 819743002: Add more methods to delegates for more upstreaming (Closed)

Created:
6 years ago by gone
Modified:
5 years, 12 months ago
Reviewers:
Maria
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add more methods to delegates for more upstreaming * ActivityDelegate takes in classes instead of Strings so that you can do isInstance on them. * TabDelegate introduces a new function for creating Tabs in a specific case. BUG=443773 Committed: https://crrev.com/70a416cda7ed16e55f3c3c32bb25457cba1feaa5 Cr-Commit-Position: refs/heads/master@{#309447}

Patch Set 1 #

Messages

Total messages: 7 (2 generated)
gone
6 years ago (2014-12-20 00:46:49 UTC) #2
Maria
lgtm
5 years, 12 months ago (2014-12-22 03:01:51 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819743002/1
5 years, 12 months ago (2014-12-22 17:42:38 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-22 19:23:40 UTC) #6
commit-bot: I haz the power
5 years, 12 months ago (2014-12-22 19:24:36 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/70a416cda7ed16e55f3c3c32bb25457cba1feaa5
Cr-Commit-Position: refs/heads/master@{#309447}

Powered by Google App Engine
This is Rietveld 408576698