Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2242)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java

Issue 819743002: Add more methods to delegates for more upstreaming (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java
index b2c00bbb96899bb4c3fa15bcc5e47671a3ea8799..edf4e5de0bee5e91349ec2000ca32cac63a5f4cf 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/document/TabDelegate.java
@@ -7,7 +7,9 @@ package org.chromium.chrome.browser.tabmodel.document;
import android.app.Activity;
import org.chromium.chrome.browser.Tab;
+import org.chromium.chrome.browser.document.PendingDocumentData;
import org.chromium.chrome.browser.tabmodel.document.DocumentTabModel.Entry;
+import org.chromium.content_public.browser.LoadUrlParams;
/**
* Provides Tabs to a DocumentTabModel.
@@ -23,6 +25,13 @@ public interface TabDelegate {
Tab getActivityTab(boolean incognito, ActivityDelegate delgate, Activity activity);
/**
+ * Opens a new Tab in the foreground.
+ * Assumed to be triggered by a window.open().
+ */
+ void createTabInForeground(Activity parentActivity, boolean incognito,
+ LoadUrlParams loadUrlParams, PendingDocumentData documentParams);
+
+ /**
* Creates a frozen Tab for the Entry.
* @param entry Entry containing TabState.
* @return A frozen Tab.

Powered by Google App Engine
This is Rietveld 408576698