Load V8 external data prior to initializng PDFium SDK.

Load V8 external data prior to initializng PDFium SDK.

Under XFA, PDFium will always attempt to start V8 as part of the SDK
initialization, and will segv if the external data has not yet been
loaded.

BUG=439793
Committed: https://crrev.com/3c703774c2958ebd2b1f877725900232fc3a4c1f
Cr-Commit-Position: refs/heads/master@{#309712}

[Tom Sepez, 2014-12-18 20:40:48]

tsepez@chromium.org changed reviewers:
+ jochen@chromium.org

[Tom Sepez, 2014-12-18 20:40:48]

Jochen, 
this works around the current problem, but I need someone more savvy than myself
to tell if this will introduce issues. Please review or suggest an alternate. 
Thanks!

[jochen (gone - plz use gerrit), 2014-12-19 14:48:32]

jochen@chromium.org changed reviewers:
+ raymes@chromium.org, rmcilroy@chromium.org

[jochen (gone - plz use gerrit), 2014-12-19 14:48:32]

+ross, raymes

[raymes, 2014-12-21 22:52:03]

lgtm

https://codereview.chromium.org/819473002/diff/1/pdf/instance.cc
File pdf/instance.cc (right):

https://codereview.chromium.org/819473002/diff/1/pdf/instance.cc#newcode44
pdf/instance.cc:44: #include "v8/include/v8.h"
nit: I think we can remove this include now

https://codereview.chromium.org/819473002/diff/1/pdf/out_of_process_instance.cc
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/819473002/diff/1/pdf/out_of_process_instance....
pdf/out_of_process_instance.cc:43: #include "v8/include/v8.h"
nit: I think we can remove this include now

[Tom Sepez, 2014-12-29 18:18:37]

https://codereview.chromium.org/819473002/diff/1/pdf/instance.cc
File pdf/instance.cc (right):

https://codereview.chromium.org/819473002/diff/1/pdf/instance.cc#newcode44
pdf/instance.cc:44: #include "v8/include/v8.h"
On 2014/12/21 22:52:02, raymes wrote:
> nit: I think we can remove this include now

Done.

https://codereview.chromium.org/819473002/diff/1/pdf/out_of_process_instance.cc
File pdf/out_of_process_instance.cc (right):

https://codereview.chromium.org/819473002/diff/1/pdf/out_of_process_instance....
pdf/out_of_process_instance.cc:43: #include "v8/include/v8.h"
On 2014/12/21 22:52:02, raymes wrote:
> nit: I think we can remove this include now

Done.

[Tom Sepez, 2014-12-29 18:18:51]

The CQ bit was checked by tsepez@chromium.org

[commit-bot: I haz the power, 2014-12-29 18:19:58]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819473002/20001

[commit-bot: I haz the power, 2014-12-29 19:05:09]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2014-12-29 19:05:55]

Patchset 2 (id:??) landed as
https://crrev.com/3c703774c2958ebd2b1f877725900232fc3a4c1f
Cr-Commit-Position: refs/heads/master@{#309712}