Load V8 external data prior to initializng PDFium SDK.

pdf/instance.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "pdf/instance.h"
 
 #include <algorithm>  // for min()
 #define _USE_MATH_DEFINES  // for M_PI
 #include <cmath>      // for log() and pow()
 #include <math.h>
@@ skipping 23 matching lines @@
 #include "ppapi/cpp/dev/font_dev.h"
 #include "ppapi/cpp/dev/memory_dev.h"
 #include "ppapi/cpp/dev/text_input_dev.h"
 #include "ppapi/cpp/module.h"
 #include "ppapi/cpp/point.h"
 #include "ppapi/cpp/private/pdf.h"
 #include "ppapi/cpp/rect.h"
 #include "ppapi/cpp/resource.h"
 #include "ppapi/cpp/url_request_info.h"
 #include "ui/events/keycodes/keyboard_codes.h"
 #include "v8/include/v8.h"

[raymes, 2014/12/21 22:52:02]

nit: I think we can remove this include now

[Tom Sepez, 2014/12/29 18:18:37]

Done.

 
 #if defined(OS_MACOSX)
 #include "base/mac/mac_util.h"
 #endif
 
 namespace chrome_pdf {
 
 struct ToolbarButtonInfo {
   uint32 id;
   Button::ButtonStyle style;
@@ skipping 270 matching lines @@
     timer_factory_.CancelAll();
     timer_pending_ = false;
   }
   // The engine may try to access this instance during its destruction.
   // Make sure this happens early while the instance is still intact.
   engine_.reset();
   RemovePerInstanceObject(kPPPPdfInterface, this);
 }
 
 bool Instance::Init(uint32_t argc, const char* argn[], const char* argv[]) {
-  v8::StartupData natives;
-  v8::StartupData snapshot;
-  pp::PDF::GetV8ExternalSnapshotData(this, &natives.data, &natives.raw_size,
-                                     &snapshot.data, &snapshot.raw_size);
-  if (natives.data) {
-    v8::V8::SetNativesDataBlob(&natives);
-    v8::V8::SetSnapshotDataBlob(&snapshot);
-  }
-
   // For now, we hide HiDPI support behind a flag.
   if (pp::PDF::IsFeatureEnabled(this, PP_PDFFEATURE_HIDPI))
     hidpi_enabled_ = true;
 
   printing_enabled_ = pp::PDF::IsFeatureEnabled(this, PP_PDFFEATURE_PRINTING);
   if (printing_enabled_) {
     CreateToolbar(kPDFToolbarButtons, arraysize(kPDFToolbarButtons));
   } else {
     CreateToolbar(kPDFNoPrintToolbarButtons,
                   arraysize(kPDFNoPrintToolbarButtons));
@@ skipping 2445 matching lines @@
   return instance_->HasScriptableMethod(name, exception);
 }
 
 pp::Var PDFScriptableObject::Call(const pp::Var& method,
                                   const std::vector<pp::Var>& args,
                                   pp::Var* exception) {
   return instance_->CallScriptableMethod(method, args, exception);
 }
 
 }  // namespace chrome_pdf