Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(122)

Issue 819403003: Fix assertion condition in asan_symbolize.py. (Closed)

Created:
5 years, 12 months ago by Alexander Potapenko
Modified:
5 years, 12 months ago
Reviewers:
inferno
CC:
chromium-reviews, glider+watch_chromium.org, timurrrr+watch_chromium.org, bruening+watch_chromium.org, earthdok
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix assertion condition in asan_symbolize.py. In the case when an app is inside a framework, app_positions[0] should be greater than framework_positions[0]. BUG=444343 TBR=inferno@chromium.org NOTRY=true Committed: https://crrev.com/5adbb0a9a3ea03b83ff8117fb6e7c346ed9b36aa Cr-Commit-Position: refs/heads/master@{#309626}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M tools/valgrind/asan/asan_symbolize.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (1 generated)
Alexander Potapenko
TBR
5 years, 12 months ago (2014-12-24 09:42:26 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/819403003/1
5 years, 12 months ago (2014-12-24 09:42:59 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 12 months ago (2014-12-24 09:43:43 UTC) #4
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5adbb0a9a3ea03b83ff8117fb6e7c346ed9b36aa Cr-Commit-Position: refs/heads/master@{#309626}
5 years, 12 months ago (2014-12-24 09:44:27 UTC) #5
inferno
5 years, 12 months ago (2014-12-24 14:02:22 UTC) #6
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698