tools/valgrind/asan/asan_symbolize.py - Issue 819403003: Fix assertion condition in asan_symbolize.py.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/valgrind/asan/asan_symbolize.py

Issue 819403003: Fix assertion condition in asan_symbolize.py. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/valgrind/asan/asan_symbolize.py

diff --git a/tools/valgrind/asan/asan_symbolize.py b/tools/valgrind/asan/asan_symbolize.py

index 8a32681f0156e730db815074f24e8cde29211c18..9e7d50419348548665bc2f34b8671581b2669b4f 100755

--- a/tools/valgrind/asan/asan_symbolize.py

+++ b/tools/valgrind/asan/asan_symbolize.py

@@ -77,7 +77,7 @@ def chrome_dsym_hints(binary):

return []

assert (not (len(app_positions) == 1 and

len(framework_positions) == 1 and

- app_positions[0] < framework_positions[0])), \

+ app_positions[0] > framework_positions[0])), \

"The path contains an app bundle inside a framework: %s" % binary

# Cases 2 and 3. The outermost bundle (which is the only bundle in the case 2)

# is located in the product dir.

« no previous file with comments | « no previous file | no next file » | no next file with comments »