Enable Windows to load V8's initial snapshot from external files.

Enable Windows to load V8's initial snapshot from external files.

Not yet enabled by default.

BUG=421063, 439661
Committed: https://crrev.com/ceeb241d83ba97554dca023fca8bec6aff30a300
Cr-Commit-Position: refs/heads/master@{#310792}

[rmcilroy, 2015-01-09 13:39:23]

rmcilroy@chromium.org changed reviewers:
+ grt@chromium.org, jochen@chromium.org

[rmcilroy, 2015-01-09 13:39:24]

This is a rebase of https://codereview.chromium.org/765053003/.  Now that we
have snapshot verification on Windows we should be able to land this.  PTAL,
thanks.

grt@chromium.org: Please review changes in chrome/installer

jochen@chromium.org: Please review changes in gin

[jochen (gone - plz use gerrit), 2015-01-09 13:40:24]

lgtm with nit

https://codereview.chromium.org/819203003/diff/1/gin/isolate_holder.cc
File gin/isolate_holder.cc (right):

https://codereview.chromium.org/819203003/diff/1/gin/isolate_holder.cc#newcode51
gin/isolate_holder.cc:51: #ifndef OS_WIN
#if !defined(OS_WIN)

[rmcilroy, 2015-01-09 14:16:33]

https://codereview.chromium.org/819203003/diff/1/gin/isolate_holder.cc
File gin/isolate_holder.cc (right):

https://codereview.chromium.org/819203003/diff/1/gin/isolate_holder.cc#newcode51
gin/isolate_holder.cc:51: #ifndef OS_WIN
On 2015/01/09 13:40:24, jochen (slow) wrote:
> #if !defined(OS_WIN)

argh, that was the one thing I planned on changing from the original CL but
forgot to after I got a merge conflict :).  Done.

[rmcilroy, 2015-01-09 14:56:30]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2015-01-09 14:57:01]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819203003/20001

[commit-bot: I haz the power, 2015-01-09 15:00:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-09 15:00:46]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_32_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[grt (UTC plus 2), 2015-01-09 16:25:55]

lgtm

[rmcilroy, 2015-01-09 16:57:47]

The CQ bit was checked by rmcilroy@chromium.org

[commit-bot: I haz the power, 2015-01-09 16:59:17]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819203003/40001

[commit-bot: I haz the power, 2015-01-09 17:54:44]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-01-09 17:55:41]

Patchset 3 (id:??) landed as
https://crrev.com/ceeb241d83ba97554dca023fca8bec6aff30a300
Cr-Commit-Position: refs/heads/master@{#310792}