Enable Windows to load V8's initial snapshot from external files.

gin/isolate_holder.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "gin/public/isolate_holder.h"
 
 #include <stdlib.h>
 #include <string.h>
 
 #include "base/files/memory_mapped_file.h"
@@ skipping 30 matching lines @@
 base::MemoryMappedFile* g_mapped_natives = NULL;
 base::MemoryMappedFile* g_mapped_snapshot = NULL;
 
 #if defined(V8_USE_EXTERNAL_STARTUP_DATA)
 bool MapV8Files(base::FilePath* natives_path, base::FilePath* snapshot_path,
                 int natives_fd = -1, int snapshot_fd = -1) {
   int flags = base::File::FLAG_OPEN | base::File::FLAG_READ;
 
   g_mapped_natives = new base::MemoryMappedFile;
   if (!g_mapped_natives->IsValid()) {
+#ifndef OS_WIN

[jochen (gone - plz use gerrit), 2015/01/09 13:40:24]

#if !defined(OS_WIN)

[rmcilroy, 2015/01/09 14:16:33]

argh, that was the one thing I planned on changing from the original CL but
forgot to after I got a merge conflict :).  Done.

     if (natives_fd == -1
         ? !g_mapped_natives->Initialize(base::File(*natives_path, flags))
         : !g_mapped_natives->Initialize(base::File(natives_fd))) {
+#else
+    if (!g_mapped_natives->Initialize(base::File(*natives_path, flags))) {
+#endif  // OS_WIN
       delete g_mapped_natives;
       g_mapped_natives = NULL;
       LOG(FATAL) << "Couldn't mmap v8 natives data file";
       return false;
     }
   }
 
   g_mapped_snapshot = new base::MemoryMappedFile;
   if (!g_mapped_snapshot->IsValid()) {
+#ifndef OS_WIN
     if (snapshot_fd == -1
         ? !g_mapped_snapshot->Initialize(base::File(*snapshot_path, flags))
         : !g_mapped_snapshot->Initialize(base::File(snapshot_fd))) {
+#else
+    if (!g_mapped_snapshot->Initialize(base::File(*snapshot_path, flags))) {
+#endif  // OS_WIN
       delete g_mapped_snapshot;
       g_mapped_snapshot = NULL;
       LOG(ERROR) << "Couldn't mmap v8 snapshot data file";
       return false;
     }
   }
 
   return true;
 }
 
 #if defined(V8_VERIFY_EXTERNAL_STARTUP_DATA)
 bool VerifyV8SnapshotFile(base::MemoryMappedFile* snapshot_file,
                           const unsigned char* fingerprint) {
   unsigned char output[crypto::kSHA256Length];
   crypto::SHA256HashString(
       base::StringPiece(reinterpret_cast<const char*>(snapshot_file->data()),
                         snapshot_file->length()),
       output, sizeof(output));
   return !memcmp(fingerprint, output, sizeof(output));
 }
 #endif  // V8_VERIFY_EXTERNAL_STARTUP_DATA
 
 #if !defined(OS_MACOSX)
 const int v8_snapshot_dir =
 #if defined(OS_ANDROID)
     base::DIR_ANDROID_APP_DATA;
 #elif defined(OS_POSIX)
     base::DIR_EXE;
+#elif defined(OS_WIN)
+    base::DIR_MODULE;
 #endif  // OS_ANDROID
 #endif  // !OS_MACOSX
 
 #endif  // V8_USE_EXTERNAL_STARTUP_DATA
 
 }  // namespace
 
 #if defined(V8_USE_EXTERNAL_STARTUP_DATA)
 
 #if defined(V8_VERIFY_EXTERNAL_STARTUP_DATA)
@@ skipping 137 matching lines @@
   base::MessageLoop::current()->AddTaskObserver(task_observer_.get());
 }
 
 void IsolateHolder::RemoveRunMicrotasksObserver() {
   DCHECK(task_observer_.get());
   base::MessageLoop::current()->RemoveTaskObserver(task_observer_.get());
   task_observer_.reset();
 }
 
 }  // namespace gin