Plugin Power Saver: Fix DETECT in WebsiteSettingsUI omnibox dropdown.

Plugin Power Saver: Fix DETECT in WebsiteSettingsUI omnibox dropdown.

This is the followup to https://codereview.chromium.org/822823002/ that fixes the crash for DETECT.

This is lower priority than the preceding bug, since it only affects 41/Canary, but it still addresses a crash.

BUG=444524
Committed: https://crrev.com/a0c1a9c441ab6c7e7b934f66cce3dbdb9968f4b8
Cr-Commit-Position: refs/heads/master@{#309608}

[tommycli, 2014-12-22 22:29:08]

tommycli@chromium.org changed reviewers:
+ markusheintz@chromium.org

[tommycli, 2014-12-22 22:29:43]

markushenitz_: PTAL at this also.

This is the followup to the other patch I sent you today.

This one only affects 41, so should not be merged into 40 and 39 like the other
one.

[markusheintz_, 2014-12-23 16:45:26]

On 2014/12/22 22:29:43, tommycli wrote:
> markushenitz_: PTAL at this also.
> 
> This is the followup to the other patch I sent you today.
> 
> This one only affects 41, so should not be merged into 40 and 39 like the
other
> one.

LGTM

Again I'm not sure if you can merge string changes because the strings need to
be translated first.

[tommycli, 2014-12-23 20:54:10]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-12-23 20:54:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819183002/1

[commit-bot: I haz the power, 2014-12-23 20:57:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-23 20:57:46]

Try jobs failed on following builders:
  win_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/win_gpu/builds/10...)
  android_aosp on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_aosp/bu...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_compile...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  ios_dbg_simulator on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator...)
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)
  mac_chromium_rel_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)

[tommycli, 2014-12-23 21:12:07]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-12-23 21:12:42]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819183002/20001

[commit-bot: I haz the power, 2014-12-23 21:18:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-23 21:18:35]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tommycli, 2014-12-23 21:37:17]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-12-23 21:37:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819183002/20001

[commit-bot: I haz the power, 2014-12-23 21:43:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-23 21:43:11]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tommycli, 2014-12-23 21:56:39]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-12-23 21:57:04]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819183002/20001

[commit-bot: I haz the power, 2014-12-23 22:02:39]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-23 22:02:40]

Try jobs failed on following builders:
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  chromium_presubmit on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[tommycli, 2014-12-23 22:09:57]

tommycli@chromium.org changed reviewers:
+ groby@chromium.org

[tommycli, 2014-12-23 22:09:58]

groby: Need mac OWNER to review
chrome/browser/ui/cocoa/website_settings/permission_selector_button.mm.

Small change. Thanks!

[groby-ooo-7-16, 2014-12-23 22:24:42]

c/b/ui/cocoa LGTM

[tommycli, 2014-12-24 00:38:46]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-12-24 00:39:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819183002/20001

[commit-bot: I haz the power, 2014-12-24 01:26:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-12-24 01:26:56]

Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[tommycli, 2014-12-24 01:58:46]

The CQ bit was checked by tommycli@chromium.org

[commit-bot: I haz the power, 2014-12-24 01:59:26]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/819183002/40001

[commit-bot: I haz the power, 2014-12-24 02:48:07]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2014-12-24 02:48:59]

Patchset 3 (id:??) landed as
https://crrev.com/a0c1a9c441ab6c7e7b934f66cce3dbdb9968f4b8
Cr-Commit-Position: refs/heads/master@{#309608}