Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8172)

Unified Diff: chrome/browser/ui/website_settings/website_settings_ui.cc

Issue 819183002: Plugin Power Saver: Fix DETECT in WebsiteSettingsUI omnibox dropdown. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@0210-plugin-power-saver-fix-website-settings-plugin-ask-backportable
Patch Set: fix mac stuff Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/website_settings/website_settings_ui.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/website_settings/website_settings_ui.cc
diff --git a/chrome/browser/ui/website_settings/website_settings_ui.cc b/chrome/browser/ui/website_settings/website_settings_ui.cc
index 2591d6e16b072f33cf5f66ce917102f1f9c1f069..9ee7e692f86966d2adf11a2e0a70c19c15cbb360 100644
--- a/chrome/browser/ui/website_settings/website_settings_ui.cc
+++ b/chrome/browser/ui/website_settings/website_settings_ui.cc
@@ -50,7 +50,7 @@ const int kPermissionButtonTextIDUserManaged[] = {
IDS_WEBSITE_SETTINGS_BUTTON_TEXT_BLOCKED_BY_USER,
IDS_WEBSITE_SETTINGS_BUTTON_TEXT_ASK_BY_USER,
kInvalidResourceID,
- kInvalidResourceID};
+ IDS_WEBSITE_SETTINGS_BUTTON_TEXT_DETECT_IMPORTANT_CONTENT_BY_USER};
static_assert(arraysize(kPermissionButtonTextIDUserManaged) ==
CONTENT_SETTING_NUM_SETTINGS,
"kPermissionButtonTextIDUserManaged array size is incorrect");
@@ -157,13 +157,21 @@ base::string16 WebsiteSettingsUI::PermissionValueToUIString(
// static
base::string16 WebsiteSettingsUI::PermissionActionToUIString(
- ContentSetting setting,
- ContentSetting default_setting,
- content_settings::SettingSource source) {
+ ContentSettingsType type,
+ ContentSetting setting,
+ ContentSetting default_setting,
+ content_settings::SettingSource source) {
ContentSetting effective_setting = setting;
- if (effective_setting == CONTENT_SETTING_DEFAULT)
+ if (effective_setting == CONTENT_SETTING_DEFAULT) {
effective_setting = default_setting;
+ // For Plugins, ASK is obsolete. Show as BLOCK to reflect actual behavior.
+ if (type == CONTENT_SETTINGS_TYPE_PLUGINS &&
+ default_setting == CONTENT_SETTING_ASK) {
+ effective_setting = CONTENT_SETTING_BLOCK;
+ }
+ }
+
const int* button_text_ids = NULL;
switch (source) {
case content_settings::SETTING_SOURCE_USER:
« no previous file with comments | « chrome/browser/ui/website_settings/website_settings_ui.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698