Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2765)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc

Issue 819083002: Fix AppModalDialogHelper to deal with a TabStrip without an active tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc ('K') | « chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc
diff --git a/chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc b/chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc
index aeb72d5f060fcecaa72d8199a297a0f2b9e5b518..afe72e1437ef51bdbb65e934a8bd166f571fde5a 100644
--- a/chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc
+++ b/chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc
@@ -12,7 +12,8 @@
JavaScriptAppModalDialogViewsX11::JavaScriptAppModalDialogViewsX11(
app_modal::JavaScriptAppModalDialog* parent)
: app_modal::JavaScriptAppModalDialogViews(parent),
- helper_(new AppModalDialogHelper(parent->web_contents())) {
+ helper_(
+ new AppModalDialogHelper(parent ? parent->web_contents() : nullptr)) {
}
JavaScriptAppModalDialogViewsX11::~JavaScriptAppModalDialogViewsX11() {
« chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc ('K') | « chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698