chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc - Issue 819083002: Fix AppModalDialogHelper to deal with a TabStrip without an active tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc

Issue 819083002: Fix AppModalDialogHelper to deal with a TabStrip without an active tab (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm ('K') | « chrome/browser/ui/cocoa/javascript_app_modal_dialog_cocoa.mm ('k') | chrome/browser/ui/views/javascript_app_modal_dialog_views_x11.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc

diff --git a/chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc b/chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc

index c93e8a7c7e02c423fe1c2ef7c77896ab2905cece..ca2c5a8dcd03001112718a0dfd50918d1d7cdf9e 100644

--- a/chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc

+++ b/chrome/browser/ui/views/chrome_javascript_native_dialog_factory_views.cc

@@ -25,7 +25,8 @@ class ChromeJavaScriptAppModalDialogViews

explicit ChromeJavaScriptAppModalDialogViews(

app_modal::JavaScriptAppModalDialog* parent)

: app_modal::JavaScriptAppModalDialogViews(parent),

- helper_(new AppModalDialogHelper(parent->web_contents())) {}

+ helper_(

+ new AppModalDialogHelper(parent ? parent->web_contents() : NULL)) {}

Bernhard Bauer 2014/12/22 13:18:35 nullptr

virtual ~ChromeJavaScriptAppModalDialogViews() {}

private: