Chromium Code Reviews Chromium Code Reviews
Issue
818853004:
Revert of media: Optimize HW Video to 2D Canvas copy. (Closed)
DescriptionRevert of media: Optimize HW Video to 2D Canvas copy. (patchset #20 id:780001 of https://codereview.chromium.org/445013002/)
Note: This is *not* meant to be committed as it only breaks android downstream.
Reason for revert:
This change breaks android browser_content_tests. It was only catched by downstream bots. Reverting for now.
Original issue's description:
> media: Optimize HW Video to 2D Canvas copy.
>
> Currently, when we draws GPU decoded Video on accelerated 2D Canvas, chromium
> reads back pixel from GPU and then uploads the pixel to GPU to make a SkBitmap.
> It's so inefficient for both speed and battery. On the other hand, only Android
> copies GPU-GPU in this case, but Android doesn't have cache mechanism which
> SkCanvasVideoRenderer provides.
>
> This CL makes all platforms copy gpu-gpu with cache mechanism. Cache mechanism
> is useful when 2d canvas draws a video frame many times.
> e.g. http://craftymind.com/factory/html5video/CanvasVideo.html
>
> In addition, fix white video background on Android when not loaded. Other platforms
> draw black background thanks to SkCanvasVideoRenderer::Paint().
>
> In detail of the changes;
> 1. Implement gpu-gpu copy in SkCanvasVideoRenderer::Paint() like previous
> WebMediaPlayerAndroid::paint().
> 2. Move duplicated GPU code on WebMediaPlayerImpl and WebMediaPlayerAndroid to
> SkCanvasVideoRenderer.
>
> Perf data on i5 IvyBridge
> blink_perf.all:Canvas_draw-video-to-hw-accelerated-canvas-2d
> 15.8x speed up: 116.27 runs/s -> 1847.23 runs/s
> NOTE: measure after disabling cache in SkCanvasVideoRenderer
>
> BUG=401058, 263667
>
> Committed: https://crrev.com/0c4e9d8781aea6e52fdb4a7aee978817910c67ea
> Cr-Commit-Position: refs/heads/master@{#310577}
TBR=thestig@chromium.org,scherkus@chromium.org,junov@chromium.org,rileya@chromium.org,ben@chromium.org,sievers@chromium.org,creis@chromium.org,aa@chromium.org,xhwang@chromium.org,dongseong.hwang@intel.com
NOTREECHECKS=true
NOTRY=true
BUG=401058, 263667
Patch Set 1 #
Created: 5 years, 11 months ago
(Patch set is too large to download)
Messages
Total messages: 7 (1 generated)
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
