Source/platform/heap/InlinedGlobalMarkingVisitor.h - Issue 818253005: Oilpan: Query stack frame register instead of manual bookkeeping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/InlinedGlobalMarkingVisitor.h

Issue 818253005: Oilpan: Query stack frame register instead of manual bookkeeping (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: need more depth to cause non-eager trace for arm32 Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/InlinedGlobalMarkingVisitor.h

diff --git a/Source/platform/heap/InlinedGlobalMarkingVisitor.h b/Source/platform/heap/InlinedGlobalMarkingVisitor.h

index b3708e87f2c4b39023405ffd227ee9099c8af0d8..106be4571f40d8e4fc55b7dceff41e32101d2061 100644

--- a/Source/platform/heap/InlinedGlobalMarkingVisitor.h

+++ b/Source/platform/heap/InlinedGlobalMarkingVisitor.h

@@ -52,9 +52,7 @@ public:

using Impl::ensureMarked;

- inline bool canTraceEagerly() const { return m_visitor->canTraceEagerly(); }

- inline void incrementTraceDepth() { m_visitor->incrementTraceDepth(); }

- inline void decrementTraceDepth() { m_visitor->decrementTraceDepth(); }

+ inline bool canTraceEagerly() { return Visitor::canTraceEagerly(); }

Visitor* getUninlined() { return m_visitor; }

« Source/platform/heap/Heap.cpp ('K') | « Source/platform/heap/HeapTest.cpp ('k') | Source/platform/heap/StackFrameDepth.h » ('j') | Source/platform/heap/Visitor.h » ('J')