Source/platform/heap/Heap.cpp - Issue 818253005: Oilpan: Query stack frame register instead of manual bookkeeping

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/platform/heap/Heap.cpp

Issue 818253005: Oilpan: Query stack frame register instead of manual bookkeeping (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: need more depth to cause non-eager trace for arm32 Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/platform/heap/Heap.cpp

diff --git a/Source/platform/heap/Heap.cpp b/Source/platform/heap/Heap.cpp

index a25225c2bec962e07edfa8b4c754650f1be0cf4e..2d0f4893c72e90d715d2a62cdb080334b940fab6 100644

--- a/Source/platform/heap/Heap.cpp

+++ b/Source/platform/heap/Heap.cpp

@@ -2308,6 +2308,8 @@ void Heap::collectGarbage(ThreadState::StackState stackState, ThreadState::GCTyp

ThreadState::NoAllocationScope noAllocationScope(state);

preGC();

+ s_markingVisitor->configureEagerTraceLimit();

sof 2015/01/14 07:03:43 Move this to preGC() ?

+ ASSERT(s_markingVisitor->canTraceEagerly());

Heap::resetMarkedObjectSize();

Heap::resetAllocatedObjectSize();

@@ -2363,6 +2365,7 @@ void Heap::collectGarbageForTerminatingThread(ThreadState* state)

ThreadState::NoAllocationScope noAllocationScope(state);

state->preGC();

+ s_markingVisitor->configureEagerTraceLimit();

// 1. Trace the thread local persistent roots. For thread local GCs we

// don't trace the stack (ie. no conservative scanning) since this is

« no previous file with comments | « Source/platform/heap/BUILD.gn ('k') | Source/platform/heap/HeapTest.cpp » ('j') | Source/platform/heap/Visitor.h » ('J')