Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(15)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 818103002: Make callers of CommandLine use it via the base:: namespace. (Closed)

Created:
6 years ago by Avi (use Gerrit)
Modified:
6 years ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, browser-components-watch_chromium.org, jam, darin-cc_chromium.org, mkwst+moarreviews-renderer_chromium.org, estade+watch_chromium.org, gcasto+watchlist_chromium.org, rouslan+autofillwatch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make callers of CommandLine use it via the base:: namespace. Covers cloud_print/ and components/. BUG=422426 TEST=none TBR=ben@chromium.org Committed: https://crrev.com/1772c1ae7194b0efdbd3c65d1654902daabb1c51 Cr-Commit-Position: refs/heads/master@{#309475}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+78 lines, -73 lines) Patch
M components/autofill/content/renderer/password_autofill_agent.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/autofill/core/browser/autofill_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/copresence/rpc/rpc_handler.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/browser/password_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/password_manager/core/common/experiments.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/browser/browser_policy_connector.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/policy/core/common/cloud/cloud_policy_constants.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/policy/core/common/cloud/cloud_policy_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/precache/content/precache_manager.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/precache/content/precache_manager_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/precache/core/precache_fetcher.cc View 2 chunks +4 lines, -2 lines 0 comments Download
M components/precache/core/precache_fetcher_unittest.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M components/proximity_auth/cryptauth/cryptauth_client.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search/search.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/search/search_android_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/template_url.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/search_engines/template_url_prepopulate_data_unittest.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M components/search_engines/template_url_unittest.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M components/session_manager/core/session_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/account_tracker_service.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/signin_manager_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/common/profile_management_switches.cc View 4 chunks +14 lines, -15 lines 0 comments Download
M components/translate/core/browser/translate_download_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/browser/translate_manager.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/browser/translate_script.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/translate/core/browser/translate_script_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/common/translate_util.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/translate/core/common/translate_util_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/user_manager/user_manager_base.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/variations_seed_processor.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/variations/variations_seed_processor_unittest.cc View 8 chunks +9 lines, -9 lines 0 comments Download
M components/wallpaper/wallpaper_manager_base.cc View 1 chunk +4 lines, -4 lines 0 comments Download
M components/web_resource/resource_request_allowed_notifier.cc View 1 chunk +2 lines, -1 line 0 comments Download
M components/wifi/wifi_test.cc View 2 chunks +4 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/818103002/1
6 years ago (2014-12-22 22:11:29 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
6 years ago (2014-12-22 22:43:03 UTC) #3
commit-bot: I haz the power
6 years ago (2014-12-22 22:43:43 UTC) #4
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1772c1ae7194b0efdbd3c65d1654902daabb1c51
Cr-Commit-Position: refs/heads/master@{#309475}

Powered by Google App Engine
This is Rietveld 408576698