components/search_engines/template_url_unittest.cc - Issue 818103002: Make callers of CommandLine use it via the base:: namespace.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/search_engines/template_url_unittest.cc

Issue 818103002: Make callers of CommandLine use it via the base:: namespace. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/search_engines/template_url_prepopulate_data_unittest.cc ('k') | components/session_manager/core/session_manager.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/search_engines/template_url_unittest.cc

diff --git a/components/search_engines/template_url_unittest.cc b/components/search_engines/template_url_unittest.cc

index 555783289da16f74ac7686c37a0999b0143d68ce..b16e7b42b1a644b055eb0bc9983b934c48f72349 100644

--- a/components/search_engines/template_url_unittest.cc

+++ b/components/search_engines/template_url_unittest.cc

@@ -1247,7 +1247,7 @@ TEST_F(TemplateURLTest, SuggestQueryParams) {

// Add extra_query_params in the mix, and ensure it works.

search_terms.append_extra_query_params = true;

- CommandLine::ForCurrentProcess()->AppendSwitchASCII(

+ base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(

switches::kExtraSearchQueryParams, "a=b");

EXPECT_EQ("http://www.google.com/search?a=b&pq=xyz&q=abc#oq=def&x",

url.url_ref().ReplaceSearchTerms(search_terms, search_terms_data_));

@@ -1276,7 +1276,7 @@ TEST_F(TemplateURLTest, ExtraQueryParams) {

url.url_ref().ReplaceSearchTerms(search_terms, search_terms_data_));

// Now append the command-line arg. This should be inserted into the query.

- CommandLine::ForCurrentProcess()->AppendSwitchASCII(

+ base::CommandLine::ForCurrentProcess()->AppendSwitchASCII(

switches::kExtraSearchQueryParams, "a=b");

EXPECT_EQ("http://www.google.com/search?a=b&q=abc#oq=def&x",

url.url_ref().ReplaceSearchTerms(search_terms, search_terms_data_));