Source/bindings/modules/dart/custom/DartAudioContextCustom.cpp - Issue 817913005: Track some changes to reference types (mostly Blink types moving to Oilpan).

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/bindings/modules/dart/custom/DartAudioContextCustom.cpp

Issue 817913005: Track some changes to reference types (mostly Blink types moving to Oilpan). (Closed) Base URL: svn://svn.chromium.org/blink/branches/dart/dartium

Patch Set: Created 5 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/bindings/dart/scripts/templates/callback_interface_h.template ('k') | Source/bindings/modules/dart/custom/DartDeviceMotionEventCustom.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/bindings/modules/dart/custom/DartAudioContextCustom.cpp

diff --git a/Source/bindings/modules/dart/custom/DartAudioContextCustom.cpp b/Source/bindings/modules/dart/custom/DartAudioContextCustom.cpp

index 55941dbf41df92d17b25ec7c11fb85344eabe825..a370ec263b3375ed1dd1f5bfc63fbe692847aa09 100644

--- a/Source/bindings/modules/dart/custom/DartAudioContextCustom.cpp

+++ b/Source/bindings/modules/dart/custom/DartAudioContextCustom.cpp

@@ -56,16 +56,16 @@ void decodeAudioDataCallback(Dart_NativeArguments args)

if (exception)

goto fail;

- OwnPtr<AudioBufferCallback> successCallback = DartAudioBufferCallback::create(Dart_GetNativeArgument(args, 2), exception);

+ AudioBufferCallback* successCallback = DartAudioBufferCallback::create(Dart_GetNativeArgument(args, 2), exception);

if (exception)

goto fail;

- OwnPtr<AudioBufferCallback> errorCallback = DartAudioBufferCallback::createWithNullCheck(Dart_GetNativeArgument(args, 3), exception);

+ AudioBufferCallback* errorCallback = DartAudioBufferCallback::createWithNullCheck(Dart_GetNativeArgument(args, 3), exception);

if (exception)

goto fail;

DartExceptionState es;

- receiver->decodeAudioData(audioData.get(), successCallback.release(), errorCallback.release(), es);

+ receiver->decodeAudioData(audioData.get(), successCallback, errorCallback, es);

if (es.hadException()) {

exception = es.toDart(args);

goto fail;