Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3595)

Unified Diff: chrome/test/chromedriver/element_util.h

Issue 817913004: [chromedriver] Make GetElementLocationInView return the top-left coordinate rather than the center (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comment to ScrollElementIntoView() Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/test/chromedriver/element_commands.cc ('k') | chrome/test/data/chromedriver/multiline.html » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/element_util.h
diff --git a/chrome/test/chromedriver/element_util.h b/chrome/test/chromedriver/element_util.h
index 142fd646c7801a11b24b556ee5d0c3436fcf54ab..a1a0813846d3966ea1d2889ee89e484c3140122a 100644
--- a/chrome/test/chromedriver/element_util.h
+++ b/chrome/test/chromedriver/element_util.h
@@ -127,6 +127,11 @@ Status ToggleOptionElement(
WebView* web_view,
const std::string& element_id);
+// |offset| is an optional offset from the top-left of the first ClientRect
+// that is returned by the element's getClientRects() function.
+// If |offset| is null, the |location| returned will be the center of the
+// ClientRect. If it is non-null, |location| will be offset by the specified
+// value.
Status ScrollElementIntoView(
Session* session,
WebView* web_view,
« no previous file with comments | « chrome/test/chromedriver/element_commands.cc ('k') | chrome/test/data/chromedriver/multiline.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698