Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4062)

Unified Diff: chrome/test/chromedriver/element_commands.cc

Issue 817913004: [chromedriver] Make GetElementLocationInView return the top-left coordinate rather than the center (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: add comment to ScrollElementIntoView() Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/test/chromedriver/element_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/test/chromedriver/element_commands.cc
diff --git a/chrome/test/chromedriver/element_commands.cc b/chrome/test/chromedriver/element_commands.cc
index 3eb07a2b8979e0f6ce6fc2b7b1289ee5741ba1fc..0dcf7b3f114068acd81fad326c6c21de204565ab 100644
--- a/chrome/test/chromedriver/element_commands.cc
+++ b/chrome/test/chromedriver/element_commands.cc
@@ -443,9 +443,10 @@ Status ExecuteGetElementLocationOnceScrolledIntoView(
const std::string& element_id,
const base::DictionaryValue& params,
scoped_ptr<base::Value>* value) {
+ WebPoint offset(0, 0);
WebPoint location;
Status status = ScrollElementIntoView(
- session, web_view, element_id, nullptr, &location);
+ session, web_view, element_id, &offset, &location);
if (status.IsError())
return status;
value->reset(CreateValueFrom(location));
« no previous file with comments | « no previous file | chrome/test/chromedriver/element_util.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698