Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issue 817913004: [chromedriver] Make GetElementLocationInView return the top-left coordinate rather than the center (Closed)

Created:
5 years, 11 months ago by samuong
Modified:
5 years, 11 months ago
Reviewers:
stgao
CC:
chromium-reviews, samuong+watch_chromium.org, stgao
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[chromedriver] Make GetElementLocationInView return the top-left coordinate rather than the center Also fix testMoveToElementAndClick on Android. BUG= Committed: https://crrev.com/45d9b0f1767cb5ad834a2f55e42ec49a4d69d239 Cr-Commit-Position: refs/heads/master@{#311556}

Patch Set 1 #

Patch Set 2 : fix testMoveToElementAndClick on android, tested on emulator and using mobile emulation #

Patch Set 3 : add comment to ScrollElementIntoView() #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -3 lines) Patch
M chrome/test/chromedriver/element_commands.cc View 1 chunk +2 lines, -1 line 0 comments Download
M chrome/test/chromedriver/element_util.h View 1 2 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/test/data/chromedriver/multiline.html View 1 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
samuong
crrev.com/848483002 caused GetElementLocationInView to start returning the mid-point of the first ClientRect of the element. ...
5 years, 11 months ago (2015-01-14 19:24:33 UTC) #2
stgao
lgtm It might be good to add a comment on input/output for ScrollElementIntoView.
5 years, 11 months ago (2015-01-14 19:36:30 UTC) #3
samuong
Done
5 years, 11 months ago (2015-01-14 20:25:14 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817913004/40001
5 years, 11 months ago (2015-01-14 20:25:58 UTC) #6
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 11 months ago (2015-01-14 22:34:43 UTC) #7
commit-bot: I haz the power
5 years, 11 months ago (2015-01-14 22:36:14 UTC) #8
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/45d9b0f1767cb5ad834a2f55e42ec49a4d69d239
Cr-Commit-Position: refs/heads/master@{#311556}

Powered by Google App Engine
This is Rietveld 408576698