Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Issue 817723005: move remaining virtual draw methods to onDraw (Closed)

Created:
5 years, 11 months ago by reed2
Modified:
5 years, 11 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

move remaining virtual draw methods to onDraw BUG=skia: Committed: https://skia.googlesource.com/skia/+/2e0f7d53bba5438c9bf11ee5ccae2c301e348419

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : ptal #

Patch Set 4 : #

Patch Set 5 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+585 lines, -489 lines) Patch
M gyp/skia_for_android_framework_defines.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M gyp/skia_for_chromium_defines.gypi View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M include/core/SkCanvas.h View 1 15 chunks +38 lines, -14 lines 0 comments Download
M include/core/SkImage.h View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M include/utils/SkDeferredCanvas.h View 1 2 2 chunks +25 lines, -27 lines 0 comments Download
M include/utils/SkDumpCanvas.h View 1 2 chunks +21 lines, -19 lines 0 comments Download
M include/utils/SkLuaCanvas.h View 1 2 chunks +21 lines, -20 lines 0 comments Download
M include/utils/SkNWayCanvas.h View 1 2 chunks +21 lines, -28 lines 0 comments Download
M include/utils/SkProxyCanvas.h View 1 2 chunks +21 lines, -25 lines 0 comments Download
M src/core/SkCanvas.cpp View 12 chunks +82 lines, -27 lines 0 comments Download
M src/core/SkPictureRecord.h View 1 2 2 chunks +24 lines, -21 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 1 11 chunks +20 lines, -21 lines 0 comments Download
M src/core/SkRecorder.h View 1 2 chunks +21 lines, -41 lines 0 comments Download
M src/core/SkRecorder.cpp View 1 4 chunks +33 lines, -33 lines 0 comments Download
M src/pipe/SkGPipeWrite.cpp View 1 2 13 chunks +42 lines, -43 lines 0 comments Download
M src/utils/SkDeferredCanvas.cpp View 1 2 8 chunks +23 lines, -25 lines 0 comments Download
M src/utils/SkDumpCanvas.cpp View 1 2 4 chunks +51 lines, -18 lines 0 comments Download
M src/utils/SkLuaCanvas.cpp View 1 2 3 chunks +36 lines, -15 lines 0 comments Download
M src/utils/SkNWayCanvas.cpp View 1 3 chunks +23 lines, -26 lines 0 comments Download
M src/utils/SkProxyCanvas.cpp View 1 2 3 3 chunks +26 lines, -24 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.h View 1 2 chunks +21 lines, -34 lines 0 comments Download
M src/utils/debugger/SkDebugCanvas.cpp View 1 2 6 chunks +28 lines, -21 lines 0 comments Download
M tests/RecordDrawTest.cpp View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
M tests/TileGridTest.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 17 (6 generated)
reed2
5 years, 11 months ago (2015-01-02 19:39:13 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817723005/40001
5 years, 11 months ago (2015-01-03 05:19:12 UTC) #4
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-03 05:19:13 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot on client.skia (http://build.chromium.org/p/client.skia/builders/Test-Ubuntu13.10-GCE-NoGPU-x86_64-Release-Shared-Trybot/builds/1377) Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1737)
5 years, 11 months ago (2015-01-03 05:21:17 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817723005/60001
5 years, 11 months ago (2015-01-03 05:28:15 UTC) #9
commit-bot: I haz the power
Note for Reviewers: The CQ is waiting for an approval. If you believe that the ...
5 years, 11 months ago (2015-01-03 05:28:16 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: Build-Win-VS2013-x86-Debug-Trybot on client.skia.compile (http://build.chromium.org/p/client.skia.compile/builders/Build-Win-VS2013-x86-Debug-Trybot/builds/1739)
5 years, 11 months ago (2015-01-03 05:31:47 UTC) #12
bsalomon
lgtm
5 years, 11 months ago (2015-01-05 02:22:05 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817723005/80001
5 years, 11 months ago (2015-01-05 04:59:29 UTC) #15
commit-bot: I haz the power
Committed patchset #5 (id:80001) as https://skia.googlesource.com/skia/+/2e0f7d53bba5438c9bf11ee5ccae2c301e348419
5 years, 11 months ago (2015-01-05 05:09:08 UTC) #16
reed2
5 years, 11 months ago (2015-01-05 12:48:18 UTC) #17
Message was sent while issue was closed.
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/835913002/ by reed@chromium.org.

The reason for reverting is: did this cause chromeos heap corruption on skp?.

Powered by Google App Engine
This is Rietveld 408576698