Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(144)

Issue 817653002: Split EmbeddedWorkerDevToolsManager into two for Shared- and ServiceWorker (Closed)

Created:
6 years ago by kinuko
Modified:
6 years ago
Reviewers:
pfeldman, horo
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, vsevik, tzik, horo+watch_chromium.org, jam, serviceworker-reviews, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, nhiroki, devtools-reviews_chromium.org, kinuko+serviceworker, aandrey+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Split EmbeddedWorkerDevToolsManager into two for Shared- and ServiceWorker One more follow-up patch for https://codereview.chromium.org/761923004/#msg18 https://codereview.chromium.org/814513003/ - Split EmbeddedWorkerDevToolsManager into two, Shared- and ServiceWorkerDevToolsManager, and made them inherit from EmbeddedWorkerDevToolsManager - Renamed EmbeddedWorkerDevToolsAgentHost to WorkerDevToolsAgentHost - Renamed EmbeddedWorkerDevToolsManager to WorkerDevToolsManager BUG=443470 TEST=SharedWorkerDevToolsMangerTest\* Committed: https://crrev.com/647819d3ecb2068b37c17eaa3bc9b28f2fd4da30 Cr-Commit-Position: refs/heads/master@{#309412}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase + indent fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+549 lines, -992 lines) Patch
M content/browser/devtools/devtools_agent_host_impl.cc View 2 chunks +5 lines, -3 lines 0 comments Download
M content/browser/devtools/devtools_manager_unittest.cc View 3 chunks +3 lines, -3 lines 0 comments Download
D content/browser/devtools/embedded_worker_devtools_agent_host.h View 1 chunk +0 lines, -79 lines 0 comments Download
D content/browser/devtools/embedded_worker_devtools_agent_host.cc View 1 chunk +0 lines, -161 lines 0 comments Download
D content/browser/devtools/embedded_worker_devtools_manager.h View 1 chunk +0 lines, -120 lines 0 comments Download
D content/browser/devtools/embedded_worker_devtools_manager.cc View 1 chunk +0 lines, -213 lines 0 comments Download
D content/browser/devtools/embedded_worker_devtools_manager_unittest.cc View 1 chunk +0 lines, -298 lines 0 comments Download
M content/browser/devtools/service_worker_devtools_agent_host.h View 2 chunks +7 lines, -4 lines 0 comments Download
M content/browser/devtools/service_worker_devtools_agent_host.cc View 5 chunks +6 lines, -3 lines 0 comments Download
A content/browser/devtools/service_worker_devtools_manager.h View 1 1 chunk +87 lines, -0 lines 0 comments Download
A content/browser/devtools/service_worker_devtools_manager.cc View 1 1 chunk +97 lines, -0 lines 0 comments Download
M content/browser/devtools/shared_worker_devtools_agent_host.h View 2 chunks +5 lines, -4 lines 0 comments Download
M content/browser/devtools/shared_worker_devtools_agent_host.cc View 3 chunks +6 lines, -3 lines 0 comments Download
A content/browser/devtools/shared_worker_devtools_manager.h View 1 chunk +53 lines, -0 lines 0 comments Download
A content/browser/devtools/shared_worker_devtools_manager.cc View 1 chunk +58 lines, -0 lines 0 comments Download
A + content/browser/devtools/shared_worker_devtools_manager_unittest.cc View 18 chunks +29 lines, -29 lines 0 comments Download
A + content/browser/devtools/worker_devtools_agent_host.h View 1 4 chunks +12 lines, -18 lines 0 comments Download
A + content/browser/devtools/worker_devtools_agent_host.cc View 9 chunks +21 lines, -33 lines 0 comments Download
A content/browser/devtools/worker_devtools_manager.h View 1 1 chunk +51 lines, -0 lines 0 comments Download
A content/browser/devtools/worker_devtools_manager.cc View 1 1 chunk +84 lines, -0 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 5 chunks +6 lines, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 4 chunks +4 lines, -4 lines 0 comments Download
M content/browser/shared_worker/shared_worker_host.cc View 1 3 chunks +3 lines, -3 lines 0 comments Download
M content/browser/shared_worker/shared_worker_instance.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 2 chunks +8 lines, -4 lines 0 comments Download
M content/content_tests.gypi View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 15 (5 generated)
kinuko
pfeldman@, horo@: One more refactoring patch, can you take a look? This may look big, ...
6 years ago (2014-12-19 09:46:29 UTC) #3
pfeldman
lgtm
6 years ago (2014-12-19 12:04:11 UTC) #4
pfeldman
https://codereview.chromium.org/817653002/diff/1/content/browser/devtools/worker_devtools_manager.h File content/browser/devtools/worker_devtools_manager.h (right): https://codereview.chromium.org/817653002/diff/1/content/browser/devtools/worker_devtools_manager.h#newcode29 content/browser/devtools/worker_devtools_manager.h:29: int worker_route_id); indent
6 years ago (2014-12-19 12:04:40 UTC) #5
horo
lgtm https://codereview.chromium.org/817653002/diff/1/content/browser/devtools/worker_devtools_manager.cc File content/browser/devtools/worker_devtools_manager.cc (right): https://codereview.chromium.org/817653002/diff/1/content/browser/devtools/worker_devtools_manager.cc#newcode47 content/browser/devtools/worker_devtools_manager.cc:47: int worker_route_id) { indent
6 years ago (2014-12-22 01:54:04 UTC) #6
kinuko
Thanks! https://codereview.chromium.org/817653002/diff/1/content/browser/devtools/worker_devtools_manager.cc File content/browser/devtools/worker_devtools_manager.cc (right): https://codereview.chromium.org/817653002/diff/1/content/browser/devtools/worker_devtools_manager.cc#newcode47 content/browser/devtools/worker_devtools_manager.cc:47: int worker_route_id) { On 2014/12/22 01:54:04, horo wrote: ...
6 years ago (2014-12-22 07:06:52 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817653002/40001
6 years ago (2014-12-22 07:07:20 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_chromium_x64_rel_ng on tryserver.chromium.win (http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_rel_ng/builds/10603)
6 years ago (2014-12-22 08:45:46 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817653002/40001
6 years ago (2014-12-22 08:59:38 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:40001)
6 years ago (2014-12-22 09:55:16 UTC) #14
commit-bot: I haz the power
6 years ago (2014-12-22 09:56:10 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/647819d3ecb2068b37c17eaa3bc9b28f2fd4da30
Cr-Commit-Position: refs/heads/master@{#309412}

Powered by Google App Engine
This is Rietveld 408576698