content/browser/devtools/service_worker_devtools_agent_host.h - Issue 817653002: Split EmbeddedWorkerDevToolsManager into two for Shared- and ServiceWorker

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/devtools/service_worker_devtools_agent_host.h

Issue 817653002: Split EmbeddedWorkerDevToolsManager into two for Shared- and ServiceWorker (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebase + indent fixes Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « content/browser/devtools/embedded_worker_devtools_manager_unittest.cc ('k') | content/browser/devtools/service_worker_devtools_agent_host.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/browser/devtools/service_worker_devtools_agent_host.h

diff --git a/content/browser/devtools/service_worker_devtools_agent_host.h b/content/browser/devtools/service_worker_devtools_agent_host.h

index b11cb4f8c3474ef0d9a36d87a76edb2b84536e68..5c78d8a8ac578cf11ca4363f258c3ff69c56de5b 100644

--- a/content/browser/devtools/service_worker_devtools_agent_host.h

+++ b/content/browser/devtools/service_worker_devtools_agent_host.h

@@ -5,12 +5,16 @@

#ifndef CONTENT_BROWSER_DEVTOOLS_SERVICE_WORKER_DEVTOOLS_AGENT_HOST_H_

#define CONTENT_BROWSER_DEVTOOLS_SERVICE_WORKER_DEVTOOLS_AGENT_HOST_H_

-#include "content/browser/devtools/embedded_worker_devtools_agent_host.h"

+#include "content/browser/devtools/service_worker_devtools_manager.h"

+#include "content/browser/devtools/worker_devtools_agent_host.h"

namespace content {

-class ServiceWorkerDevToolsAgentHost : public EmbeddedWorkerDevToolsAgentHost {

+class ServiceWorkerDevToolsAgentHost : public WorkerDevToolsAgentHost {

public:

+ typedef ServiceWorkerDevToolsManager::ServiceWorkerIdentifier

+ ServiceWorkerIdentifier;

ServiceWorkerDevToolsAgentHost(WorkerId worker_id,

const ServiceWorkerIdentifier& service_worker,

bool debug_service_worker_on_start);

@@ -26,8 +30,7 @@ class ServiceWorkerDevToolsAgentHost : public EmbeddedWorkerDevToolsAgentHost {

void OnClientAttached() override;

void OnClientDetached() override;

- // EmbeddedWorkerDevToolsAgentHost override.

- bool Matches(const ServiceWorkerIdentifier& other) override;

+ bool Matches(const ServiceWorkerIdentifier& other);

private:

~ServiceWorkerDevToolsAgentHost() override;