Do not use hardcoded identifier in password manager user authorization

Do not use hardcoded identifier in password manager user authorization

password_manager_util_mac uses hardcoded "com.google.Chrome", since rest of the
code is pretty generic we would like to use this file directly in Opera, however
we want to use something like com.operasoftware.Opera, since that information is
can already be retrieved from [base::mac::MainBundle() bundleIdentifier] we can
just use it and append ".show-passwords".

BUG=447344
Committed: https://crrev.com/6a4346b2119c1155aea9835478895fbe2660a1d2
Cr-Commit-Position: refs/heads/master@{#317037}

[Jiang Jiang, 2014-12-22 16:52:46]

jiangj@opera.com changed reviewers:
+ albertb@chromium.org

[Jiang Jiang, 2015-01-08 17:40:48]

jiangj@opera.com changed reviewers:
+ gcasto@chromium.org

[Jiang Jiang, 2015-01-08 17:40:48]

Ping, can any of you take a look?

[Mike West, 2015-01-08 17:47:09]

mkwst@chromium.org changed reviewers:
+ dconnelly@chromium.org, mkwst@chromium.org

[Mike West, 2015-01-08 17:47:09]

This looks pretty reasonable to me, but I am not an Obj-C person, nor am I going
to pretend to be one. :) +dconnelly.

[dconnelly, 2015-01-08 17:56:36]

Is there a bug for this?

https://codereview.chromium.org/817333002/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/password_manager_util_mac.mm (right):

https://codereview.chromium.org/817333002/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/password_manager_util_mac.mm:24: [[identifier
stringByAppendingString:@".show-passwords"] UTF8String];
Don't use [NSString UTF8String]. Use base::SysNSStringToUTF8 from
base/strings/sys_string_conversions.h.

[Jiang Jiang, 2015-01-08 21:05:51]

On 2015/01/08 17:56:36, dconnelly wrote:
> Is there a bug for this?
> 
>
https://codereview.chromium.org/817333002/diff/1/chrome/browser/password_mana...
> File chrome/browser/password_manager/password_manager_util_mac.mm (right):
> 
>
https://codereview.chromium.org/817333002/diff/1/chrome/browser/password_mana...
> chrome/browser/password_manager/password_manager_util_mac.mm:24: [[identifier
> stringByAppendingString:@".show-passwords"] UTF8String];
> Don't use [NSString UTF8String]. Use base::SysNSStringToUTF8 from
> base/strings/sys_string_conversions.h.

Thanks for the review, I will make a bug.

[Jiang Jiang, 2015-01-08 21:41:58]

https://codereview.chromium.org/817333002/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/password_manager_util_mac.mm (right):

https://codereview.chromium.org/817333002/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/password_manager_util_mac.mm:24: [[identifier
stringByAppendingString:@".show-passwords"] UTF8String];
On 2015/01/08 17:56:36, dconnelly wrote:
> Don't use [NSString UTF8String]. Use base::SysNSStringToUTF8 from
> base/strings/sys_string_conversions.h.

But I will have to call c_str() out of this still, since

typedef const char* AuthorizationString;

Do you really think it is worth it?

[dconnelly, 2015-01-09 09:06:03]

lgtm. You still need a chrome/browser/password_manager OWNER to rubber-stamp,
though. Punting back to mkwst.

https://codereview.chromium.org/817333002/diff/1/chrome/browser/password_mana...
File chrome/browser/password_manager/password_manager_util_mac.mm (right):

https://codereview.chromium.org/817333002/diff/1/chrome/browser/password_mana...
chrome/browser/password_manager/password_manager_util_mac.mm:24: [[identifier
stringByAppendingString:@".show-passwords"] UTF8String];
On 2015/01/08 21:41:58, Jiang Jiang wrote:
> On 2015/01/08 17:56:36, dconnelly wrote:
> > Don't use [NSString UTF8String]. Use base::SysNSStringToUTF8 from
> > base/strings/sys_string_conversions.h.
> 
> But I will have to call c_str() out of this still, since
> 
> typedef const char* AuthorizationString;
> 
> Do you really think it is worth it?

No, this is fine then. git grep shows more uses of [NSString UTF8String] than it
does SysNSStringToUTF8.*c_str.

[Mike West, 2015-01-09 09:07:18]

If Daniel's happy, I'm happy. rs LGTM.

[Jiang Jiang, 2015-02-19 13:05:04]

The CQ bit was checked by jiangj@opera.com

[commit-bot: I haz the power, 2015-02-19 13:06:19]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/817333002/1

[commit-bot: I haz the power, 2015-02-19 13:48:21]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-02-19 13:48:49]

Patchset 1 (id:??) landed as
https://crrev.com/6a4346b2119c1155aea9835478895fbe2660a1d2
Cr-Commit-Position: refs/heads/master@{#317037}