Do not use hardcoded identifier in password manager user authorization

chrome/browser/password_manager/password_manager_util_mac.mm

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/password_manager/password_manager_util.h"
 
 #include <CoreFoundation/CoreFoundation.h>
 #import <Foundation/Foundation.h>
 #include <Security/Authorization.h>
 
 #include "base/basictypes.h"
 #include "base/mac/authorization_util.h"
+#include "base/mac/bundle_locations.h"
 #include "base/mac/foundation_util.h"
 #include "base/mac/scoped_authorizationref.h"
 #include "chrome/grit/chromium_strings.h"
 #include "ui/base/l10n/l10n_util.h"
 
 namespace password_manager_util {
 
 bool AuthenticateUser(gfx::NativeWindow window) {
+  NSString* identifier = [base::mac::MainBundle() bundleIdentifier];
+  AuthorizationString name =
+      [[identifier stringByAppendingString:@".show-passwords"] UTF8String];

[dconnelly, 2015/01/08 17:56:36]

Don't use [NSString UTF8String]. Use base::SysNSStringToUTF8 from
base/strings/sys_string_conversions.h.

[Jiang Jiang, 2015/01/08 21:41:58]

But I will have to call c_str() out of this still, since

typedef const char* AuthorizationString;

Do you really think it is worth it?

[dconnelly, 2015/01/09 09:06:03]

No, this is fine then. git grep shows more uses of [NSString UTF8String] than it
does SysNSStringToUTF8.*c_str.

   AuthorizationItem right_items[] = {
-    {"com.google.Chrome.show-passwords", 0, NULL, 0}
+    {name, 0, NULL, 0}
   };
   AuthorizationRights rights = {arraysize(right_items), right_items};
 
   NSString* prompt =
       l10n_util::GetNSString(IDS_PASSWORDS_PAGE_AUTHENTICATION_PROMPT);
 
   // Pass kAuthorizationFlagDestroyRights to prevent the OS from saving the
   // authorization and not prompting the user when future requests are made.
   base::mac::ScopedAuthorizationRef authorization(
       base::mac::GetAuthorizationRightsWithPrompt(
           &rights, base::mac::NSToCFCast(prompt),
           kAuthorizationFlagDestroyRights));
   return authorization.get() != NULL;
 }
 
 // TODO(dubroy): Implement on Mac.
 void GetOsPasswordStatus(const base::Callback<void(OsPasswordStatus)>& reply) {
   reply.Run(PASSWORD_STATUS_UNSUPPORTED);
 }
 
 }  // namespace password_manager_util