Issue 81733003: Fixing crash of AnimationCompositorAnimationsTest.ConvertTimingForCompositorIterationCount on Andro…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 81733003: Fixing crash of AnimationCompositorAnimationsTest.ConvertTimingForCompositorIterationCount on Andro… (Closed)

Created:
7 years, 1 month ago by mithro-old

Modified:
7 years, 1 month ago

Reviewers:
Steve Block

CC:
blink-reviews, shans, rjwright, alancutter (OOO until 2018), Mike Lawther (Google), dstockwell, Timothy Loh, darktears, Steve Block, dino_apple.com, Eric Willigers

Base URL:
https://chromium.googlesource.com/chromium/blink.git@master

Visibility:
Public.

More Reviews

Description

Fixing crash of AnimationCompositorAnimationsTest.ConvertTimingForCompositorIterationCount on Android. This patch reverts "Disable CoreAnimationCompositorAnimationsTest.ConvertTimingForCompositorIterationCount" This reverts commit 6cfa03ad78ce5b46f0b78dfccc1ef503ad505654. (Also merges the ConvertTimingForCompositorInfinite test into ConvertTimingForCompositorIterationCount.) BUG=319674 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=162509

Patch Set 1 #

Patch Set 2 : Adding comments. #

Total comments: 1

Created: 7 years, 1 month ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -19 lines)			Patch
	M	Source/core/animation/CompositorAnimationsTest.cpp	View	1	3 chunks	+15 lines, -19 lines	1 comment	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

mithro-old

Hi Steve, If you get a spare moment, please take a look at this patch. ...

7 years, 1 month ago (2013-11-22 02:07:44 UTC) #1

Steve Block

lgtm https://codereview.chromium.org/81733003/diff/30001/Source/core/animation/CompositorAnimationsTest.cpp File Source/core/animation/CompositorAnimationsTest.cpp (right): https://codereview.chromium.org/81733003/diff/30001/Source/core/animation/CompositorAnimationsTest.cpp#newcode375 Source/core/animation/CompositorAnimationsTest.cpp:375: // EXPECT_DEATH tests are flaky on Android. So ...

7 years, 1 month ago (2013-11-22 02:56:34 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mithro@mithis.com/81733003/30001

7 years, 1 month ago (2013-11-22 03:00:32 UTC) #3

Message was sent while issue was closed.

Change committed as 162509

Expand Messages | Collapse Messages