Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(770)

Issue 817243002: Avoid leaking render targets in debugger (Closed)

Created:
5 years, 12 months ago by Kimmo Kinnunen
Modified:
5 years, 12 months ago
Reviewers:
robertphillips
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Avoid leaking render targets in debugger Render targets were not unreffed when QGLWidget::resizeGL was called. Committed: https://skia.googlesource.com/skia/+/4be0238b116cb271122f26d0114540d15dce5bf1

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -38 lines) Patch
M debugger/QT/SkGLWidget.h View 1 chunk +5 lines, -4 lines 0 comments Download
M debugger/QT/SkGLWidget.cpp View 2 chunks +36 lines, -34 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Kimmo Kinnunen
5 years, 12 months ago (2014-12-22 09:50:38 UTC) #2
robertphillips
lgtm
5 years, 12 months ago (2014-12-22 13:53:20 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/817243002/1
5 years, 12 months ago (2014-12-22 13:54:25 UTC) #5
commit-bot: I haz the power
5 years, 12 months ago (2014-12-22 14:06:44 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/4be0238b116cb271122f26d0114540d15dce5bf1

Powered by Google App Engine
This is Rietveld 408576698