Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/drive.

Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/drive.

The Google style guide states that only one of {virtual,override,final}
should be used for each declaration, since override implies virtual and
final implies both virtual and override.

This patch was automatically generated with a ChromeOS build using a
variation of https://codereview.chromium.org/598073004.

BUG=417463
R=hirono@chromium.org

Committed: https://crrev.com/fe7733035fb94012163f74864416d321382c0e28
Cr-Commit-Position: refs/heads/master@{#312655}

[dcheng, 2015-01-20 18:24:01]

dcheng@chromium.org changed reviewers:
+ hidehiko@chromium.org

[hashimoto, 2015-01-21 04:50:11]

hashimoto@chromium.org changed reviewers:
+ hashimoto@chromium.org

[hashimoto, 2015-01-21 04:50:12]

lgtm with nits

https://codereview.chromium.org/817063006/diff/1/chrome/browser/chromeos/driv...
File chrome/browser/chromeos/drive/change_list_loader_unittest.cc (right):

https://codereview.chromium.org/817063006/diff/1/chrome/browser/chromeos/driv...
chrome/browser/chromeos/drive/change_list_loader_unittest.cc:39:
~TestChangeListLoaderObserver() override { loader_->RemoveObserver(this); }
nit: I think RemoveObserver should be better placed in a new line.

https://codereview.chromium.org/817063006/diff/1/chrome/browser/chromeos/driv...
chrome/browser/chromeos/drive/change_list_loader_unittest.cc:58: void
OnInitialLoadComplete() override { ++initial_load_complete_count_; }
ditto.

https://codereview.chromium.org/817063006/diff/1/chrome/browser/chromeos/driv...
File chrome/browser/chromeos/drive/directory_loader_unittest.cc (right):

https://codereview.chromium.org/817063006/diff/1/chrome/browser/chromeos/driv...
chrome/browser/chromeos/drive/directory_loader_unittest.cc:39:
~TestDirectoryLoaderObserver() override { loader_->RemoveObserver(this); }
nit: I think RemoveObserver should be better placed in a new line.

https://codereview.chromium.org/817063006/diff/1/chrome/browser/chromeos/driv...
File chrome/browser/chromeos/drive/drive_integration_service_unittest.cc
(right):

https://codereview.chromium.org/817063006/diff/1/chrome/browser/chromeos/driv...
chrome/browser/chromeos/drive/drive_integration_service_unittest.cc:27: void
SetUp() override { ASSERT_TRUE(profile_manager_.SetUp()); }
nit: I think ASSERT_TRUE should be better placed in a new line.

https://codereview.chromium.org/817063006/diff/1/chrome/browser/chromeos/driv...
File chrome/browser/chromeos/drive/file_system_util_unittest.cc (right):

https://codereview.chromium.org/817063006/diff/1/chrome/browser/chromeos/driv...
chrome/browser/chromeos/drive/file_system_util_unittest.cc:42: void SetUp()
override { ASSERT_TRUE(testing_profile_manager_.SetUp()); }
nit: I think ASSERT_TRUE should be better placed in a new line.

https://codereview.chromium.org/817063006/diff/1/chrome/browser/chromeos/driv...
File chrome/browser/chromeos/drive/file_write_watcher_unittest.cc (right):

https://codereview.chromium.org/817063006/diff/1/chrome/browser/chromeos/driv...
chrome/browser/chromeos/drive/file_write_watcher_unittest.cc:66: void SetUp()
override { ASSERT_TRUE(temp_dir_.CreateUniqueTempDir()); }
nit: I think ASSERT_TRUE should be better placed in a new line.

[hidehiko, 2015-01-21 06:29:57]

lgtm, but defer to the current owners (hashimoto & hirono).

FYI: I guess you can remove "inline empty destructors marked override".

[dcheng, 2015-01-21 07:02:50]

clang-format prefers to collapse short inline functions into one line. I've had
several reviewers question this in the past, which resulted in this thread:
https://groups.google.com/a/chromium.org/forum/#!topic/chromium-dev/H8tYKcetScU

The conclusion from that thread is the clang-format style follows
Google/Chromium style, so this should be fine. If that's OK with you, I'd like
to proceed with the patch as is (as I'd prefer not to have to fight clang-format
again in future patches).

[dcheng, 2015-01-21 07:03:53]

On 2015/01/21 at 06:29:57, hidehiko wrote:
> lgtm, but defer to the current owners (hashimoto & hirono).
> 
> FYI: I guess you can remove "inline empty destructors marked override".

For smaller patches, I was doing this manually but the CrOS patches are large
enough that I don't really have time to do this kind of manual processing step.
Sorry =(

[dcheng, 2015-01-22 08:31:40]

Ping, to confirm that clang-format changes are acceptable as-is. I'd really like
to get this landed--there are just a few minor fixups needed after this before
this flag can be enabled for CrOS.

[hashimoto, 2015-01-22 09:03:38]

On 2015/01/22 08:31:40, dcheng wrote:
> Ping, to confirm that clang-format changes are acceptable as-is. I'd really
like
> to get this landed--there are just a few minor fixups needed after this before
> this flag can be enabled for CrOS.

Hmm, I really don't like unnecessarily losing git-blame history for the changed
lines, but it's not unacceptable if you really don't like opposing
clang-format...
lgtm

[dcheng, 2015-01-22 18:26:16]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-01-22 18:27:31]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/817063006/1

[commit-bot: I haz the power, 2015-01-22 18:34:08]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-01-22 18:34:09]

Try jobs failed on following builders:
  linux_gpu on tryserver.chromium.gpu
(http://build.chromium.org/p/tryserver.chromium.gpu/builders/linux_gpu/builds/...)
  android_arm64_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_d...)
  android_chromium_gn_compile_dbg on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_chromium_gn_compile_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromiu...)
  android_clang_dbg_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_d...)
  android_dbg_tests_recipe on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/android_dbg_tes...)
  linux_chromium_asan_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_compile_dbg_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_gn_rel on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  win8_chromium_gn_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_gn_...)
  win8_chromium_rel on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win8_chromium_rel...)
  win_chromium_compile_dbg_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_ng on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[dcheng, 2015-01-22 18:41:58]

The CQ bit was checked by dcheng@chromium.org

[commit-bot: I haz the power, 2015-01-22 18:43:37]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/817063006/20001

[commit-bot: I haz the power, 2015-01-22 19:46:26]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2015-01-22 19:47:33]

Patchset 2 (id:??) landed as
https://crrev.com/fe7733035fb94012163f74864416d321382c0e28
Cr-Commit-Position: refs/heads/master@{#312655}