Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(939)

Side by Side Diff: chrome/browser/chromeos/drive/change_list_loader.cc

Issue 817063006: Update {virtual,override,final} to follow C++11 style in chrome/browser/chromeos/drive. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Rebase Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/change_list_loader_unittest.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/drive/change_list_loader.h" 5 #include "chrome/browser/chromeos/drive/change_list_loader.h"
6 6
7 #include <set> 7 #include <set>
8 8
9 #include "base/callback.h" 9 #include "base/callback.h"
10 #include "base/callback_helpers.h" 10 #include "base/callback_helpers.h"
(...skipping 27 matching lines...) Expand all
38 namespace { 38 namespace {
39 39
40 // Fetches all the (currently available) resource entries from the server. 40 // Fetches all the (currently available) resource entries from the server.
41 class FullFeedFetcher : public ChangeListLoader::FeedFetcher { 41 class FullFeedFetcher : public ChangeListLoader::FeedFetcher {
42 public: 42 public:
43 explicit FullFeedFetcher(JobScheduler* scheduler) 43 explicit FullFeedFetcher(JobScheduler* scheduler)
44 : scheduler_(scheduler), 44 : scheduler_(scheduler),
45 weak_ptr_factory_(this) { 45 weak_ptr_factory_(this) {
46 } 46 }
47 47
48 virtual ~FullFeedFetcher() { 48 ~FullFeedFetcher() override {}
49 }
50 49
51 virtual void Run(const FeedFetcherCallback& callback) override { 50 void Run(const FeedFetcherCallback& callback) override {
52 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 51 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
53 DCHECK(!callback.is_null()); 52 DCHECK(!callback.is_null());
54 53
55 // Remember the time stamp for usage stats. 54 // Remember the time stamp for usage stats.
56 start_time_ = base::TimeTicks::Now(); 55 start_time_ = base::TimeTicks::Now();
57 56
58 // This is full resource list fetch. 57 // This is full resource list fetch.
59 scheduler_->GetAllFileList( 58 scheduler_->GetAllFileList(
60 base::Bind(&FullFeedFetcher::OnFileListFetched, 59 base::Bind(&FullFeedFetcher::OnFileListFetched,
61 weak_ptr_factory_.GetWeakPtr(), callback)); 60 weak_ptr_factory_.GetWeakPtr(), callback));
(...skipping 42 matching lines...) Expand 10 before | Expand all | Expand 10 after
104 103
105 // Fetches the delta changes since |start_change_id|. 104 // Fetches the delta changes since |start_change_id|.
106 class DeltaFeedFetcher : public ChangeListLoader::FeedFetcher { 105 class DeltaFeedFetcher : public ChangeListLoader::FeedFetcher {
107 public: 106 public:
108 DeltaFeedFetcher(JobScheduler* scheduler, int64 start_change_id) 107 DeltaFeedFetcher(JobScheduler* scheduler, int64 start_change_id)
109 : scheduler_(scheduler), 108 : scheduler_(scheduler),
110 start_change_id_(start_change_id), 109 start_change_id_(start_change_id),
111 weak_ptr_factory_(this) { 110 weak_ptr_factory_(this) {
112 } 111 }
113 112
114 virtual ~DeltaFeedFetcher() { 113 ~DeltaFeedFetcher() override {}
115 }
116 114
117 virtual void Run(const FeedFetcherCallback& callback) override { 115 void Run(const FeedFetcherCallback& callback) override {
118 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI)); 116 DCHECK(BrowserThread::CurrentlyOn(BrowserThread::UI));
119 DCHECK(!callback.is_null()); 117 DCHECK(!callback.is_null());
120 118
121 scheduler_->GetChangeList( 119 scheduler_->GetChangeList(
122 start_change_id_, 120 start_change_id_,
123 base::Bind(&DeltaFeedFetcher::OnChangeListFetched, 121 base::Bind(&DeltaFeedFetcher::OnChangeListFetched,
124 weak_ptr_factory_.GetWeakPtr(), callback)); 122 weak_ptr_factory_.GetWeakPtr(), callback));
125 } 123 }
126 124
127 private: 125 private:
(...skipping 445 matching lines...) Expand 10 before | Expand all | Expand 10 after
573 571
574 OnChangeListLoadComplete(error); 572 OnChangeListLoadComplete(error);
575 573
576 FOR_EACH_OBSERVER(ChangeListLoaderObserver, 574 FOR_EACH_OBSERVER(ChangeListLoaderObserver,
577 observers_, 575 observers_,
578 OnLoadFromServerComplete()); 576 OnLoadFromServerComplete());
579 } 577 }
580 578
581 } // namespace internal 579 } // namespace internal
582 } // namespace drive 580 } // namespace drive
OLDNEW
« no previous file with comments | « no previous file | chrome/browser/chromeos/drive/change_list_loader_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698