Source/core/dom/Fullscreen.cpp - Issue 816953002: Remove unnecessary sync style recalc for fullscreen.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/Fullscreen.cpp

Issue 816953002: Remove unnecessary sync style recalc for fullscreen. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/dom/Fullscreen.cpp

diff --git a/Source/core/dom/Fullscreen.cpp b/Source/core/dom/Fullscreen.cpp

index 07161b2523d4083a4500da08d7fa22bdc7b64615..d31d0f8b1f63a8ded6c12e2c2e57f0461ae1eec5 100644

--- a/Source/core/dom/Fullscreen.cpp

+++ b/Source/core/dom/Fullscreen.cpp

@@ -440,9 +440,7 @@ void Fullscreen::didEnterFullScreenForElement(Element* element)

m_fullScreenElement->setContainsFullScreenElementOnAncestorsCrossingFrameBoundaries(true);

- // FIXME: This should not call updateStyleIfNeeded.

document()->setNeedsStyleRecalc(SubtreeStyleChange, StyleChangeReasonForTracing::create(StyleChangeReason::FullScreen));

- document()->updateRenderTreeIfNeeded();

m_fullScreenElement->didBecomeFullscreenElement();

« no previous file with comments | « no previous file | no next file » | no next file with comments »