Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 816933002: Fix to use ucontext_t in unwind.h. (Closed)

Created:
6 years ago by JungJik
Modified:
4 years, 7 months ago
CC:
chromium-reviews, Dai Mikurube (NOT FULLTIME)
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix to use ucontext_t in unwind.h. ucontext_t is already defined in signal.h in the latest android NDK. so it conflicts with defining _Unwind_Context ucontext_t. this patch is for fixing the conflict by using tcmalloc namespace.

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -2 lines) Patch
M third_party/tcmalloc/chromium/src/getpc.h View 1 chunk +4 lines, -2 lines 0 comments Download
M third_party/tcmalloc/chromium/src/profiler.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
JungJik
PTAL. thanks.
6 years ago (2014-12-21 08:39:10 UTC) #2
JungJik
On 2014/12/21 08:39:10, JungJik wrote: > PTAL. thanks. + Dai Mikurube : PTAL thanks.
6 years ago (2014-12-22 11:13:19 UTC) #4
Dai Mikurube (NOT FULLTIME)
It accepts both the current and older versions by using the namespace tcmalloc::, right? LGTM. ...
5 years, 12 months ago (2014-12-24 11:10:28 UTC) #5
JungJik
5 years, 12 months ago (2014-12-24 15:44:34 UTC) #6
On 2014/12/24 11:10:28, Dai Mikurube (NOT FULLTIME) wrote:
> It accepts both the current and older versions by using the namespace
> tcmalloc::, right?  LGTM. (I'm not an OWNER of these two files, though.)

yes. we are using the namespace. I think jar is resting.
we might need another owner of tcmalloc for merging and caring the latest vendor
code.
any way thanks Dai for the review and merry Christmas.

Powered by Google App Engine
This is Rietveld 408576698