Issue 816923004: Use weak cell in LoadGlobal handler.

Issue 816923004: Use weak cell in LoadGlobal handler. (Closed)

Created:
6 years ago by ulan

Modified:
6 years ago

Reviewers:
mvstanton

CC:
v8-dev

Base URL:
https://chromium.googlesource.com/v8/v8.git@master

Target Ref:
refs/pending/heads/master

Project:
v8

Visibility:
Public.

Use weak cell in LoadGlobal handler. BUG=v8:3629 LOG=N Committed: https://crrev.com/bc0d2e237b1b624bed26ba849529b40329ea72a2 Cr-Commit-Position: refs/heads/master@{#25902}

Created: 6 years ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+14 lines, -16 lines)			Patch
M	src/ic/arm/handler-compiler-arm.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ic/arm64/handler-compiler-arm64.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ic/ia32/handler-compiler-ia32.cc	View	1 chunk	+3 lines, -6 lines	0 comments	Download
M	src/ic/mips/handler-compiler-mips.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ic/x64/handler-compiler-x64.cc	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	src/ic/x87/handler-compiler-x87.cc	View	1 chunk	+3 lines, -6 lines	0 comments	Download

Total messages: 7 (2 generated)

mvstanton

LGTM. I think the 2nd location you found in this file could be dealt with ...

6 years ago (2014-12-19 12:37:19 UTC) #3

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/816923004/1

6 years ago (2014-12-19 13:09:17 UTC) #5

commit-bot: I haz the power

6 years ago (2014-12-19 13:29:02 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/bc0d2e237b1b624bed26ba849529b40329ea72a2
Cr-Commit-Position: refs/heads/master@{#25902}