src/ic/mips/handler-compiler-mips.cc - Issue 816923004: Use weak cell in LoadGlobal handler.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ic/mips/handler-compiler-mips.cc

Issue 816923004: Use weak cell in LoadGlobal handler. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 6 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/ic/mips/handler-compiler-mips.cc

diff --git a/src/ic/mips/handler-compiler-mips.cc b/src/ic/mips/handler-compiler-mips.cc

index e058876442519d597d4db05d1edc2ec7e59ef3fa..75032e1915c59bbe202b7873e8b648bdf5a5cfaf 100644

--- a/src/ic/mips/handler-compiler-mips.cc

+++ b/src/ic/mips/handler-compiler-mips.cc

@@ -701,7 +701,8 @@ Handle<Code> NamedLoadHandlerCompiler::CompileLoadGlobal(

// Get the value from the cell.

- __ li(result, Operand(cell));

+ Handle<WeakCell> weak_cell = factory()->NewWeakCell(cell);

+ __ LoadWeakValue(result, weak_cell, &miss);

__ lw(result, FieldMemOperand(result, Cell::kValueOffset));

// Check for deleted property if property can actually be deleted.

« no previous file with comments | « src/ic/ia32/handler-compiler-ia32.cc ('k') | src/ic/x64/handler-compiler-x64.cc » ('j') | no next file with comments »