Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(108)

Unified Diff: mojo/services/gpu/public/interfaces/gpu.mojom

Issue 816913004: Review nullability in the gpu and geometry interfaces. (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « mojo/services/gpu/public/interfaces/command_buffer.mojom ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: mojo/services/gpu/public/interfaces/gpu.mojom
diff --git a/mojo/services/gpu/public/interfaces/gpu.mojom b/mojo/services/gpu/public/interfaces/gpu.mojom
index 4b74035ac6589adcfdb732a7465ff774687f9bd4..4e0ef5137350c469590ffd12fb927ad75bbf6bcc 100644
--- a/mojo/services/gpu/public/interfaces/gpu.mojom
+++ b/mojo/services/gpu/public/interfaces/gpu.mojom
@@ -10,8 +10,8 @@ import "mojo/services/gpu/public/interfaces/viewport_parameter_listener.mojom";
interface Gpu {
CreateOnscreenGLES2Context(uint64 native_viewport_id,
- Size? size,
- CommandBuffer&? gles2_client,
- ViewportParameterListener? listener);
- CreateOffscreenGLES2Context(CommandBuffer&? gles2_client);
+ Size size,
+ CommandBuffer& gles2_client,
+ ViewportParameterListener listener);
jamesr 2015/01/08 23:16:29 this broke mojo:sample_app. This field is valid to
+ CreateOffscreenGLES2Context(CommandBuffer& gles2_client);
};
« no previous file with comments | « mojo/services/gpu/public/interfaces/command_buffer.mojom ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698